Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1486863002: Revert of Track where WebContents are created in order to better understand issue. (Closed)

Created:
5 years ago by hcarmona
Modified:
5 years ago
CC:
chromium-reviews, droger+watchlist_chromium.org, blundell+watchlist_chromium.org, nasko+codewatch_chromium.org, dcheng, nyquist+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, maniscalco+watch-blimp_chromium.org, Matt Giuca, lcwu+watch_chromium.org, sdefresne+watchlist_chromium.org, marcinjb+watch-blimp_chromium.org, darin-cc_chromium.org, halliwell+watch_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org, mlamouri+watch-content_chromium.org, jennb, creis+watch_chromium.org, tapted, Peter Beverloo, jianli, oshima+watch_chromium.org, gunsch+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org, sriramsr+watch-blimp_chromium.org, tfarina, Dmitry Titov, davemoore+watch_chromium.org, dtrainor+watch-blimp_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Track where WebContents are created in order to better understand issue. (patchset #4 id:80001 of https://codereview.chromium.org/1432143002/ ) Reason for revert: Reverting Patch Set 4, since it was meant to be temporary anyways. Original issue's description: > Track where WebContents are created in order to better understand issue. > > This is a temporary change to track down a beta blocking crash. > This CL doesn't fix the crash, but will give us more information. > > The crash is happening when we attempt to show a modal dialog on some > unknown WebContents that doesn't have a WebModalDialogManager. Not all > WebContents are expecting to show modal dialogs and the creator of the > WebModalDialog doesn't control what WebContents they will get at > runtime. So, because of this loose coupling, we don't know which > WebContents is triggering the crash. > > By adding this trace we expect to learn where the WebContents are > created in order to make sure they have a WebModalDialogManager. > > BUG=538612 > > Committed: https://crrev.com/e1158d6a42903de1664c12bc91ba056ecb716bb6 > Cr-Commit-Position: refs/heads/master@{#360112} TBR=nick@chromium.org,wittman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=538612 Committed: https://crrev.com/62a2747584502c0579b78a35f68ccca4491c9b73 Cr-Commit-Position: refs/heads/master@{#362292}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M components/constrained_window/constrained_window_views.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
hcarmona
Created Revert of Track where WebContents are created in order to better understand issue.
5 years ago (2015-12-01 00:29:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486863002/1
5 years ago (2015-12-01 00:30:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486863002/1
5 years ago (2015-12-01 00:36:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 00:44:13 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-01 00:46:11 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62a2747584502c0579b78a35f68ccca4491c9b73
Cr-Commit-Position: refs/heads/master@{#362292}

Powered by Google App Engine
This is Rietveld 408576698