Issue 148683002: Remove unused param "width_" from SearchBox::OnMarginChange().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 148683002: Remove unused param "width_" from SearchBox::OnMarginChange(). (Closed)

Created:
6 years, 11 months ago by kmadhusu

Modified:
6 years, 10 months ago

Reviewers:
Chris Evans, Jered

CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove unused param "width_" from SearchBox::OnMarginChange(). This is a prep CL to fix crbug.com/247517 and crbug.com/272583. BUG=none TEST=none TBR=cevans@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247828

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -14 lines)			Patch
M	chrome/browser/ui/search/instant_ipc_sender.cc	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/common/render_messages.h	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/renderer/searchbox/searchbox.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/renderer/searchbox/searchbox.cc	View		3 chunks	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kmadhusu

cevans@chromium.org: Please review changes in render_messages.h. Thanks.

6 years, 11 months ago (2014-01-27 23:27:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/148683002/20001

6 years, 10 months ago (2014-01-29 21:51:50 UTC) #4

Message was sent while issue was closed.

Change committed as 247828

Expand Messages | Collapse Messages