Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Side by Side Diff: tools/clang/plugins/FindBadConstructsAction.cpp

Issue 1486813002: Clang style plugin: remove 'warn-only' option (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/clang/plugins/ChromeClassTester.cpp ('k') | tools/clang/plugins/Options.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "FindBadConstructsAction.h" 5 #include "FindBadConstructsAction.h"
6 6
7 #include "clang/AST/ASTConsumer.h" 7 #include "clang/AST/ASTConsumer.h"
8 #include "clang/Frontend/FrontendPluginRegistry.h" 8 #include "clang/Frontend/FrontendPluginRegistry.h"
9 9
10 #include "FindBadConstructsConsumer.h" 10 #include "FindBadConstructsConsumer.h"
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 options_.enforce_in_thirdparty_webkit = true; 55 options_.enforce_in_thirdparty_webkit = true;
56 options_.enforce_overriding_blink = true; 56 options_.enforce_overriding_blink = true;
57 } else if (args[i] == "check-enum-last-value") { 57 } else if (args[i] == "check-enum-last-value") {
58 // TODO(tsepez): Enable this by default once http://crbug.com/356815 58 // TODO(tsepez): Enable this by default once http://crbug.com/356815
59 // and http://crbug.com/356816 are fixed. 59 // and http://crbug.com/356816 are fixed.
60 options_.check_enum_last_value = true; 60 options_.check_enum_last_value = true;
61 } else if (args[i] == "with-ast-visitor") { 61 } else if (args[i] == "with-ast-visitor") {
62 options_.with_ast_visitor = true; 62 options_.with_ast_visitor = true;
63 } else if (args[i] == "check-templates") { 63 } else if (args[i] == "check-templates") {
64 options_.check_templates = true; 64 options_.check_templates = true;
65 } else if (args[i] == "warn-only") {
66 options_.warn_only = true;
67 } else { 65 } else {
68 parsed = false; 66 parsed = false;
69 llvm::errs() << "Unknown clang plugin argument: " << args[i] << "\n"; 67 llvm::errs() << "Unknown clang plugin argument: " << args[i] << "\n";
70 } 68 }
71 } 69 }
72 70
73 return parsed; 71 return parsed;
74 } 72 }
75 73
76 } // namespace chrome_checker 74 } // namespace chrome_checker
77 75
78 static FrontendPluginRegistry::Add<chrome_checker::FindBadConstructsAction> X( 76 static FrontendPluginRegistry::Add<chrome_checker::FindBadConstructsAction> X(
79 "find-bad-constructs", 77 "find-bad-constructs",
80 "Finds bad C++ constructs"); 78 "Finds bad C++ constructs");
OLDNEW
« no previous file with comments | « tools/clang/plugins/ChromeClassTester.cpp ('k') | tools/clang/plugins/Options.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698