Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1486813002: Clang style plugin: remove 'warn-only' option (Closed)

Created:
5 years ago by hans
Modified:
5 years ago
Reviewers:
Nico, dcheng
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clang style plugin: remove 'warn-only' option This was used while bringing up the plugin on Windows, but it is no longer used. BUG=467287 R=thakis@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/5823066d3178261be85fe6cad814ab01b2f5e3d4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -43 lines) Patch
M tools/clang/plugins/ChromeClassTester.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/clang/plugins/FindBadConstructsAction.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/clang/plugins/Options.h View 2 chunks +1 line, -3 lines 0 comments Download
D tools/clang/plugins/tests/warn_only.h View 1 chunk +0 lines, -21 lines 0 comments Download
D tools/clang/plugins/tests/warn_only.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
D tools/clang/plugins/tests/warn_only.flags View 1 chunk +0 lines, -1 line 0 comments Download
D tools/clang/plugins/tests/warn_only.txt View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
hans
Please take a look.
5 years ago (2015-11-30 23:03:03 UTC) #2
Nico
Lgtm, thanks!
5 years ago (2015-11-30 23:12:38 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5823066d3178261be85fe6cad814ab01b2f5e3d4 Cr-Commit-Position: refs/heads/master@{#362269}
5 years ago (2015-11-30 23:34:23 UTC) #5
hans
5 years ago (2015-11-30 23:35:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5823066d3178261be85fe6cad814ab01b2f5e3d4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698