Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Issue 1486803002: Use proper type in _createElement_2 (Closed)

Created:
5 years ago by sra1
Modified:
5 years ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org, ricow1
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use proper type in _createElement_2 Without the annotation it is possible for a (small) program to tree-shake Element. BUG= R=alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/ceaa0bdcc450acb8b66c433f7ed734d3fdf08ef4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Document.darttemplate View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sra1
5 years ago (2015-11-30 22:27:09 UTC) #2
Alan Knight
lgtm
5 years ago (2015-11-30 22:35:48 UTC) #4
sra1
5 years ago (2015-11-30 23:11:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ceaa0bdcc450acb8b66c433f7ed734d3fdf08ef4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698