Source/core/editing/markup.h - Issue 148673002: Use more const references in MarkupAccumulator and its subclasses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/markup.h

Issue 148673002: Use more const references in MarkupAccumulator and its subclasses (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/markup.h

diff --git a/Source/core/editing/markup.h b/Source/core/editing/markup.h

index 41dd3d691ed98e9aedb145619668efba45899d48..e4297e22bf95b571d6ed89b343363177f0fbfb52 100644

--- a/Source/core/editing/markup.h

+++ b/Source/core/editing/markup.h

@@ -61,8 +61,8 @@ bool isPlainTextMarkup(Node*);

void replaceChildrenWithFragment(ContainerNode*, PassRefPtr<DocumentFragment>, ExceptionState&);

void replaceChildrenWithText(ContainerNode*, const String&, ExceptionState&);

-String createMarkup(const Range*, Vector<Node*>* = 0, EAnnotateForInterchange = DoNotAnnotateForInterchange, bool convertBlocksToInlines = false, EAbsoluteURLs = DoNotResolveURLs, Node* constrainingAncestor = 0);

-String createMarkup(const Node*, EChildrenOnly = IncludeNode, Vector<Node*>* = 0, EAbsoluteURLs = DoNotResolveURLs, Vector<QualifiedName>* tagNamesToSkip = 0);

+String createMarkup(const Range*, Vector<const Node*>* = 0, EAnnotateForInterchange = DoNotAnnotateForInterchange, bool convertBlocksToInlines = false, EAbsoluteURLs = DoNotResolveURLs, Node* constrainingAncestor = 0);

+String createMarkup(const Node*, EChildrenOnly = IncludeNode, Vector<const Node*>* = 0, EAbsoluteURLs = DoNotResolveURLs, Vector<QualifiedName>* tagNamesToSkip = 0);

String createFullMarkup(const Node*);

« no previous file with comments | « Source/core/editing/MarkupAccumulator.cpp ('k') | Source/core/editing/markup.cpp » ('j') | Source/core/editing/markup.cpp » ('J')