Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1486723002: mandoline: Also add files added in gn to gyp. (Closed)

Created:
5 years ago by Elliot Glaysher
Modified:
5 years ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mandoline: Also add files added in gn to gyp. BUG=546644 Committed: https://crrev.com/9073135c8d9ede9b1b0ba230fcfaddad3ee736b0 Cr-Commit-Position: refs/heads/master@{#362229}

Patch Set 1 #

Patch Set 2 : Also depend on base i18n. #

Patch Set 3 : And fix android build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M mojo/application/public/cpp/initialize_base_and_icu.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M mojo/mojo_base.gyp View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Elliot Glaysher
5 years ago (2015-11-30 21:12:24 UTC) #2
sky
LGTM
5 years ago (2015-11-30 21:35:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486723002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486723002/40001
5 years ago (2015-11-30 21:43:44 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-30 21:52:30 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-30 21:53:13 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/9073135c8d9ede9b1b0ba230fcfaddad3ee736b0
Cr-Commit-Position: refs/heads/master@{#362229}

Powered by Google App Engine
This is Rietveld 408576698