Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1486713002: Mojo C++ bindings: Add an alias, BarAssociatedPtr, for AssociatedInterfacePtr<Bar>. (Closed)

Created:
5 years ago by yzshen1
Modified:
5 years ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: Add an alias, BarAssociatedPtr, for AssociatedInterfacePtr<Bar>. This is consistent with what we do for InterfacePtr<Bar>. BUG=546067 TEST=None Committed: https://crrev.com/2ad6044632420cfaf347b6b60f65a225b6c1cfe1 Cr-Commit-Position: refs/heads/master@{#362251}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M mojo/public/cpp/bindings/tests/associated_interface_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
yzshen1
Hi, Scott. Would you please take a look? Thanks!
5 years ago (2015-11-30 19:07:17 UTC) #2
sky
LGTM
5 years ago (2015-11-30 21:25:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486713002/1
5 years ago (2015-11-30 21:27:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 22:44:21 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-30 22:45:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ad6044632420cfaf347b6b60f65a225b6c1cfe1
Cr-Commit-Position: refs/heads/master@{#362251}

Powered by Google App Engine
This is Rietveld 408576698