pkg/analysis_server/lib/src/services/correction/fix_internal.dart - Issue 1486663003: Ensure that a complete library element has constants evaluated (issue 24890)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/correction/fix_internal.dart

Issue 1486663003: Ensure that a complete library element has constants evaluated (issue 24890) (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated after breaking changes Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart ('k') | pkg/analyzer/lib/src/context/context.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/correction/fix_internal.dart

diff --git a/pkg/analysis_server/lib/src/services/correction/fix_internal.dart b/pkg/analysis_server/lib/src/services/correction/fix_internal.dart

index 18465d0cb86177c26fe4dc78c15c29d61776c07f..f3dda2a8ac37017850797fbf9e2808f91507bdca 100644

--- a/pkg/analysis_server/lib/src/services/correction/fix_internal.dart

+++ b/pkg/analysis_server/lib/src/services/correction/fix_internal.dart

@@ -35,6 +35,7 @@ import 'package:analyzer/src/generated/scanner.dart';

import 'package:analyzer/src/generated/sdk.dart';

import 'package:analyzer/src/generated/source.dart';

import 'package:analyzer/src/generated/utilities_dart.dart';

+import 'package:analyzer/src/task/dart.dart';

import 'package:path/path.dart';

/**

@@ -1451,7 +1452,7 @@ class FixProcessor {

sdkSourceFactory.resolveUri(unitSource, libraryUri);

// prepare LibraryElement

LibraryElement libraryElement =

- context.getLibraryElement(librarySource);

+ context.getResult(librarySource, LIBRARY_ELEMENT8);

if (libraryElement == null) {

continue;

}

@@ -1484,7 +1485,7 @@ class FixProcessor {

}