pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart - Issue 1486663003: Ensure that a complete library element has constants evaluated (issue 24890)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

Issue 1486663003: Ensure that a complete library element has constants evaluated (issue 24890) (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated after breaking changes Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/analysis_server.dart ('k') | pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

index a635b8cd76d4e0c0c120a3cfb1439cd32328476c..39ee9a6a70f9025d5d530befaf05cab30e017e8b 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

@@ -146,7 +146,7 @@ class DartCompletionRequestImpl extends CompletionRequestImpl

InterfaceType get objectType {

if (_objectType == null) {

Source coreUri = context.sourceFactory.forUri('dart:core');

- LibraryElement coreLib = context.getLibraryElement(coreUri);

+ LibraryElement coreLib = context.computeLibraryElement(coreUri);

_objectType = coreLib.getType('Object').type;

}

return _objectType;