Ensure that a complete library element has constants evaluated (issue 24890)

pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.dart.cache;
 
 import 'dart:async';
 import 'dart:collection';
 
 import 'package:analysis_server/src/protocol_server.dart'
     hide Element, ElementKind;
 import 'package:analysis_server/src/services/completion/completion_manager.dart';
 import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
 import 'package:analysis_server/src/services/completion/suggestion_builder.dart';
 import 'package:analysis_server/src/services/search/search_engine.dart';
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/element.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/resolver.dart';
 import 'package:analyzer/src/generated/source.dart';
+import 'package:analyzer/src/task/dart.dart';
 
 /**
  * The `DartCompletionCache` contains cached information from a prior code
  * completion operation.
  */
 class DartCompletionCache extends CompletionCache {
   /**
    * A hash of the import directives
    * or `null` if nothing has been cached.
    */
@@ skipping 54 matching lines @@
    * or `null` if nothing has been cached.
    */
   String get importKey => _importKey;
 
   /**
    * Return the [ClassElement] for Object.
    */
   ClassElement get objectClassElement {
     if (_objectClassElement == null) {
       Source coreUri = context.sourceFactory.forUri('dart:core');
-      LibraryElement coreLib = context.getLibraryElement(coreUri);
+      LibraryElement coreLib = context.getResult(coreUri, LIBRARY_ELEMENT8);
       _objectClassElement = coreLib.getType('Object');
     }
     return _objectClassElement;
   }
 
   /**
    * Given a resolved compilation unit, compute suggestions based upon the
    * imports and other dart files (e.g. "part" files) in the library containing
    * the given compilation unit. The returned future completes when the cache
    * is populated.
@@ skipping 86 matching lines @@
         }
       }
     }
   }
 
   /**
    * Add suggestions for implicitly imported elements in dart:core.
    */
   void _addDartCoreSuggestions() {
     Source coreUri = context.sourceFactory.forUri('dart:core');
-    LibraryElement coreLib = context.getLibraryElement(coreUri);
+    LibraryElement coreLib = context.getResult(coreUri, LIBRARY_ELEMENT8);
     if (coreLib == null) {
       // If the core library has not been analyzed yet, then we cannot add any
       // suggestions from it.
       return;
     }
     Namespace coreNamespace =
         new NamespaceBuilder().createPublicNamespaceForLibrary(coreLib);
     coreNamespace.definedNames.forEach((String name, Element elem) {
       if (elem is ClassElement) {
         importedClassMap[name] = elem;
@@ skipping 69 matching lines @@
    * Add suggestions for all top level elements in the context
    * excluding those elemnents for which suggestions have already been added.
    */
   void _addNonImportedElementSuggestions(
       List<SearchMatch> matches, Set<LibraryElement> excludedLibs) {
     // Exclude internal Dart SDK libraries
     for (var lib in context.sourceFactory.dartSdk.sdkLibraries) {
       if (lib.isInternal) {
         Source libUri = context.sourceFactory.forUri(lib.shortName);
         if (libUri != null) {
-          LibraryElement libElem = context.getLibraryElement(libUri);
+          LibraryElement libElem = context.getResult(libUri, LIBRARY_ELEMENT8);
           if (libElem != null) {
             excludedLibs.add(libElem);
           }
         }
       }
     }
 
     AnalysisContext sdkContext = context.sourceFactory.dartSdk.context;
     matches.forEach((SearchMatch match) {
       if (match.kind == MatchKind.DECLARATION) {
@@ skipping 110 matching lines @@
   @override
   void visitFunctionTypeAliasElement(FunctionTypeAliasElement element) {
     cache._addSuggestion(element, DART_RELEVANCE_DEFAULT);
   }
 
   @override
   void visitTopLevelVariableElement(TopLevelVariableElement element) {
     cache._addSuggestion(element, DART_RELEVANCE_DEFAULT);
   }
 }