Offline easter egg bug fixes

Offline easter egg bug fixes
+ Fix obstacle rendering issue
+ Fix resize clipping bug

BUG=524907, 504251
Committed: https://crrev.com/6d635b9029ead03add53c7ccb5c01df4224f0453
Cr-Commit-Position: refs/heads/master@{#371497}

[edwardjung, 2015-12-08 16:14:31]

Description was changed from

==========
Formatting fixes


Offline easter egg bug fixes

BUG=
==========

to

==========
Offline easter egg bug fixes
+ Fix obstacle rendering issue
+ Fix resize clipping bug

BUG=524907,504251
==========

[edwardjung, 2016-01-25 12:29:52]

edwardjung@chromium.org changed reviewers:
+ sky@chromium.org

[edwardjung, 2016-01-25 12:29:52]

Sky, please take a look. Some updates to the easter egg.

[sky, 2016-01-25 17:27:42]

I'm not a good reviewer for JS files. Is there another OWNER you can use?

[edwardjung, 2016-01-25 17:41:02]

On 2016/01/25 17:27:42, sky wrote:
> I'm not a good reviewer for JS files. Is there another OWNER you can use?

I used to use arv@ for these but unfortunately he's no longer working on
Chromium. I'll look for someone else. 

Thanks.

[sky, 2016-01-25 17:52:41]

Maybe estade or rdevlin.

  -Scott

On Mon, Jan 25, 2016 at 9:41 AM,  <edwardjung@chromium.org> wrote:
> On 2016/01/25 17:27:42, sky wrote:
>>
>> I'm not a good reviewer for JS files. Is there another OWNER you can use?
>
>
> I used to use arv@ for these but unfortunately he's no longer working on
> Chromium. I'll look for someone else.
>
> Thanks.
>
> https://codereview.chromium.org/1486653003/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[edwardjung, 2016-01-25 18:00:49]

edwardjung@chromium.org changed reviewers:
+ estade@chromium.org

[edwardjung, 2016-01-25 18:00:49]

@estade could you take a look at the updates to the JS file.

Thanks.

[Evan Stade, 2016-01-25 22:03:53]

lgtm

[sky, 2016-01-25 23:52:37]

Rubber stamp LGTM - it would be good to make the both of you owners for these
files.

[Evan Stade, 2016-01-26 00:26:21]

On 2016/01/25 23:52:37, sky wrote:
> Rubber stamp LGTM - it would be good to make the both of you owners for these
> files.

I'd be fine with either copying the c/b/resources OWNERS file, or just adding
one with just edwardjung in it.

[edwardjung, 2016-01-26 10:42:50]

On 2016/01/26 00:26:21, Evan Stade wrote:
> On 2016/01/25 23:52:37, sky wrote:
> > Rubber stamp LGTM - it would be good to make the both of you owners for
these
> > files.
> 
> I'd be fine with either copying the c/b/resources OWNERS file, or just adding
> one with just edwardjung in it.

Thanks both. I'll add an OWNERS file in a follow up CL.

[edwardjung, 2016-01-26 10:42:58]

The CQ bit was checked by edwardjung@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-26 10:43:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1486653003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1486653003/40001

[commit-bot: I haz the power, 2016-01-26 12:38:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-26 12:38:16]

Dry run: This issue passed the CQ dry run.

[edwardjung, 2016-01-26 12:39:17]

The CQ bit was checked by edwardjung@chromium.org

[commit-bot: I haz the power, 2016-01-26 12:39:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1486653003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1486653003/40001

[commit-bot: I haz the power, 2016-01-26 12:44:19]

Description was changed from

==========
Offline easter egg bug fixes
+ Fix obstacle rendering issue
+ Fix resize clipping bug

BUG=524907,504251
==========

to

==========
Offline easter egg bug fixes
+ Fix obstacle rendering issue
+ Fix resize clipping bug

BUG=524907,504251
==========

[commit-bot: I haz the power, 2016-01-26 12:44:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-26 12:45:16]

Description was changed from

==========
Offline easter egg bug fixes
+ Fix obstacle rendering issue
+ Fix resize clipping bug

BUG=524907,504251
==========

to

==========
Offline easter egg bug fixes
+ Fix obstacle rendering issue
+ Fix resize clipping bug

BUG=524907,504251

Committed: https://crrev.com/6d635b9029ead03add53c7ccb5c01df4224f0453
Cr-Commit-Position: refs/heads/master@{#371497}
==========

[commit-bot: I haz the power, 2016-01-26 12:45:17]

Patchset 3 (id:??) landed as
https://crrev.com/6d635b9029ead03add53c7ccb5c01df4224f0453
Cr-Commit-Position: refs/heads/master@{#371497}