Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 148663007: Updated DCC navigation

Created:
6 years, 10 months ago by mkearney1
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Fixed small bugs in Multi-device and DevTools navigation outlined here: https://docs.google.com/a/google.com/spreadsheets/d/1eWmiWmCfyZ39BHW140ZBuJAZ5ef30hOVNVYMz00S5Jw/edit#gid=1939745667 Also raised exposure of Chrome Platform APIs links throughout Apps and Extensions docs. And included links to One-Time Payments doc in webstore, apps, and extensions repos.

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : #

Patch Set 13 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -61 lines) Patch
M .gitmodules View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/static/css/out/site.css View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/static/sass/_article.scss View 1 2 3 4 5 6 7 8 9 10 11 12 6 chunks +131 lines, -11 lines 0 comments Download
M chrome/common/extensions/docs/templates/json/chrome_sidenav.json View 1 2 3 4 5 6 7 8 15 chunks +52 lines, -42 lines 0 comments Download
M chrome/common/extensions/docs/templates/private/article.html View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +3 lines, -1 line 0 comments Download
A chrome/common/extensions/docs/templates/private/hidden_if_not_interesting.html View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/private/relatedpages_items.html View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +29 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/templates/public/redirects.json View 1 2 3 4 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 26 (0 generated)
mkearney1
Antony, I've added you as a reviewer, as I'm pretty sure it was you who ...
6 years, 10 months ago (2014-02-11 00:04:44 UTC) #1
asargent_no_longer_on_chrome
lgtm Is there a way to see a preview of this?
6 years, 10 months ago (2014-02-13 18:53:03 UTC) #2
mkearney
Yep. Everything is kind of a preview right now, as we aren't pushing live. How ...
6 years, 10 months ago (2014-02-13 19:04:23 UTC) #3
asargent_no_longer_on_chrome
sgtm On Thu, Feb 13, 2014 at 11:04 AM, Meggin Kearney <mkearney@google.com>wrote: > Yep. Everything ...
6 years, 10 months ago (2014-02-13 20:38:30 UTC) #4
Renato Mangini (chromium)
lgtm
6 years, 10 months ago (2014-02-13 23:38:09 UTC) #5
mkearney1
The CQ bit was checked by mkearney@chromium.org
6 years, 10 months ago (2014-02-14 00:30:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkearney@chromium.org/148663007/110004
6 years, 10 months ago (2014-02-14 00:32:35 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 00:32:37 UTC) #8
commit-bot: I haz the power
Failed to apply patch for chrome/common/extensions/docs/server2/app.yaml: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-14 00:32:37 UTC) #9
mkearney1
The CQ bit was checked by mkearney@chromium.org
6 years, 10 months ago (2014-02-14 18:27:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkearney@chromium.org/148663007/290001
6 years, 10 months ago (2014-02-14 18:28:53 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 18:28:56 UTC) #12
commit-bot: I haz the power
Failed to apply patch for chrome/common/extensions/docs/server2/app.yaml: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-14 18:28:57 UTC) #13
mkearney1
The CQ bit was checked by mkearney@chromium.org
6 years, 10 months ago (2014-02-14 18:42:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkearney@chromium.org/148663007/360001
6 years, 10 months ago (2014-02-14 18:43:13 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 19:24:50 UTC) #16
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=50386
6 years, 10 months ago (2014-02-14 19:24:51 UTC) #17
mkearney1
The CQ bit was checked by mkearney@chromium.org
6 years, 10 months ago (2014-02-18 18:47:00 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkearney@chromium.org/148663007/360001
6 years, 10 months ago (2014-02-18 18:48:23 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 18:48:24 UTC) #20
commit-bot: I haz the power
Failed to apply patch for chrome/common/extensions/docs/templates/json/chrome_sidenav.json: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-18 18:48:25 UTC) #21
mkearney1
The CQ bit was checked by mkearney@chromium.org
6 years, 10 months ago (2014-02-18 19:29:59 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkearney@chromium.org/148663007/520001
6 years, 10 months ago (2014-02-18 19:30:03 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 19:30:05 UTC) #24
commit-bot: I haz the power
Failed to apply patch for chrome/common/extensions/docs/templates/json/chrome_sidenav.json: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-18 19:30:05 UTC) #25
mkearney1
6 years, 10 months ago (2014-02-18 22:34:38 UTC) #26
I'm not going to delete this cl yet-- just just wanted to let you know that I've
created a new cl to land the last content_providers.json file updates before
launch with matching navigation and redirects:

https://codereview.chromium.org/171353002/

Powered by Google App Engine
This is Rietveld 408576698