MediaStreamRecorder: enable in Android (including linking libwebm)

MediaStreamRecorder: enable in Android (including linking libwebm)

This follows a conversation in the Intent-To-Ship [1].

The added code means:
- third_party/libwebm
- media::WebmMuxer
- content::AudioTrackRecorder
- content::VideoTrackRecorder
- content::MediaRecorderHandler.

third_party/libwebm size: 10154B

Increase in ChromePublic-unsigned.apk:
54673026 - 54651438 = 21588B ~= 21KB

----- Note:
Modified code in webm_muxer.cc due to complaint from
arm-linux-androideabi-4.9:
../../media/capture/webm_muxer.cc:49:76: error: array subscript is above array bounds [-Werror=array-bounds]
            kOpusVorbisChannelMap[params.channels() - 1], params.channels());
------

BUG=262211, 561068
TEST=Same as for desktop platform:
https://rawgit.com/Miguelao/demos/master/mediarecorder.html
Results of running it can be found under [2] and [3]

[1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/LtZYZWvVBQAJ
[2] https://drive.google.com/file/d/0B82Jhdx0kSTVS3E4bFZwZUxSSTQ/view?usp=sharing
[3] https://drive.google.com/file/d/0B82Jhdx0kSTVM3lfR2N0RFlwNzg/view?usp=sharing

Committed: https://crrev.com/f683b07078e7fba476ef33625b0b41fd6161772c
Cr-Commit-Position: refs/heads/master@{#362536}

[mcasas, 2015-11-30 21:52:05]

Patchset #1 (id:1) has been deleted

[mcasas, 2015-11-30 21:52:15]

Patchset #1 (id:20001) has been deleted

[mcasas, 2015-11-30 21:52:23]

Patchset #1 (id:40001) has been deleted

[mcasas, 2015-11-30 22:18:06]

Patchset #1 (id:60001) has been deleted

[mcasas, 2015-11-30 22:47:39]

Description was changed from

==========
[EXPERIMENTAL] MediaStreamRecorder: compile for android

BUG=262211
==========

to

==========
MediaStreamRecorder: enable in Android (including linking libwebm)

This follows a conversation in the Intent-To-Ship
(see [1]).

The added code means: 
- third_party/libwebm
- media::WebmMuxer
- content::AudioTrackRecorder
- content::VideoTrackRecorder
- content::MediaRecorderHandler.

third_party/libwebm size: 10154B

Increase in ChromePublic-unsigned.apk:
54673026 - =

BUG=262211, 561068

[1]
https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/LtZYZWvV...
==========

[mcasas, 2015-11-30 22:54:42]

Description was changed from

==========
MediaStreamRecorder: enable in Android (including linking libwebm)

This follows a conversation in the Intent-To-Ship
(see [1]).

The added code means: 
- third_party/libwebm
- media::WebmMuxer
- content::AudioTrackRecorder
- content::VideoTrackRecorder
- content::MediaRecorderHandler.

third_party/libwebm size: 10154B

Increase in ChromePublic-unsigned.apk:
54673026 - =

BUG=262211, 561068

[1]
https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/LtZYZWvV...
==========

to

==========
MediaStreamRecorder: enable in Android (including linking libwebm)

This follows a conversation in the Intent-To-Ship
(see [1]).

The added code means: 
- third_party/libwebm
- media::WebmMuxer
- content::AudioTrackRecorder
- content::VideoTrackRecorder
- content::MediaRecorderHandler.

third_party/libwebm size: 10154B

Increase in ChromePublic-unsigned.apk:
54673026 - 54651438 = 21588B ~= 21KB

BUG=262211, 561068

[1]
https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/LtZYZWvV...
==========

[mcasas, 2015-11-30 23:15:44]

Description was changed from

==========
MediaStreamRecorder: enable in Android (including linking libwebm)

This follows a conversation in the Intent-To-Ship
(see [1]).

The added code means: 
- third_party/libwebm
- media::WebmMuxer
- content::AudioTrackRecorder
- content::VideoTrackRecorder
- content::MediaRecorderHandler.

third_party/libwebm size: 10154B

Increase in ChromePublic-unsigned.apk:
54673026 - 54651438 = 21588B ~= 21KB

BUG=262211, 561068

[1]
https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/LtZYZWvV...
==========

to

==========
MediaStreamRecorder: enable in Android (including linking libwebm)

This follows a conversation in the Intent-To-Ship
(see [1]).

The added code means: 
- third_party/libwebm
- media::WebmMuxer
- content::AudioTrackRecorder
- content::VideoTrackRecorder
- content::MediaRecorderHandler.

third_party/libwebm size: 10154B

Increase in ChromePublic-unsigned.apk:
54673026 - 54651438 = 21588B ~= 21KB

Modified code in webm_muxer.cc due to complaint from
arm-linux-androideabi-4.9:
../../media/capture/webm_muxer.cc:49:76: error: array subscript is above array
bounds [-Werror=array-bounds]
            kOpusVorbisChannelMap[params.channels() - 1], params.channels());



BUG=262211, 561068

[1]
https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/LtZYZWvV...
==========

[mcasas, 2015-12-01 01:17:14]

Description was changed from

==========
MediaStreamRecorder: enable in Android (including linking libwebm)

This follows a conversation in the Intent-To-Ship
(see [1]).

The added code means: 
- third_party/libwebm
- media::WebmMuxer
- content::AudioTrackRecorder
- content::VideoTrackRecorder
- content::MediaRecorderHandler.

third_party/libwebm size: 10154B

Increase in ChromePublic-unsigned.apk:
54673026 - 54651438 = 21588B ~= 21KB

Modified code in webm_muxer.cc due to complaint from
arm-linux-androideabi-4.9:
../../media/capture/webm_muxer.cc:49:76: error: array subscript is above array
bounds [-Werror=array-bounds]
            kOpusVorbisChannelMap[params.channels() - 1], params.channels());



BUG=262211, 561068

[1]
https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/LtZYZWvV...
==========

to

==========
MediaStreamRecorder: enable in Android (including linking libwebm)

This follows a conversation in the Intent-To-Ship
(see [1]).

The added code means: 
- third_party/libwebm
- media::WebmMuxer
- content::AudioTrackRecorder
- content::VideoTrackRecorder
- content::MediaRecorderHandler.

third_party/libwebm size: 10154B

Increase in ChromePublic-unsigned.apk:
54673026 - 54651438 = 21588B ~= 21KB

----- Note: 
Modified code in webm_muxer.cc due to complaint from
arm-linux-androideabi-4.9:
../../media/capture/webm_muxer.cc:49:76: error: array subscript is above array
bounds [-Werror=array-bounds]
            kOpusVorbisChannelMap[params.channels() - 1], params.channels());
------


BUG=262211, 561068

[1]
https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/LtZYZWvV...
==========

[mcasas, 2015-12-01 01:17:43]

Description was changed from

==========
MediaStreamRecorder: enable in Android (including linking libwebm)

This follows a conversation in the Intent-To-Ship
(see [1]).

The added code means: 
- third_party/libwebm
- media::WebmMuxer
- content::AudioTrackRecorder
- content::VideoTrackRecorder
- content::MediaRecorderHandler.

third_party/libwebm size: 10154B

Increase in ChromePublic-unsigned.apk:
54673026 - 54651438 = 21588B ~= 21KB

----- Note: 
Modified code in webm_muxer.cc due to complaint from
arm-linux-androideabi-4.9:
../../media/capture/webm_muxer.cc:49:76: error: array subscript is above array
bounds [-Werror=array-bounds]
            kOpusVorbisChannelMap[params.channels() - 1], params.channels());
------


BUG=262211, 561068

[1]
https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/LtZYZWvV...
==========

to

==========
MediaStreamRecorder: enable in Android (including linking libwebm)

This follows a conversation in the Intent-To-Ship [1].

The added code means: 
- third_party/libwebm
- media::WebmMuxer
- content::AudioTrackRecorder
- content::VideoTrackRecorder
- content::MediaRecorderHandler.

third_party/libwebm size: 10154B

Increase in ChromePublic-unsigned.apk:
54673026 - 54651438 = 21588B ~= 21KB

----- Note: 
Modified code in webm_muxer.cc due to complaint from
arm-linux-androideabi-4.9:
../../media/capture/webm_muxer.cc:49:76: error: array subscript is above array
bounds [-Werror=array-bounds]
            kOpusVorbisChannelMap[params.channels() - 1], params.channels());
------


BUG=262211, 561068

[1]
https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/LtZYZWvV...
==========

[mcasas, 2015-12-01 01:19:41]

mcasas@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[mcasas, 2015-12-01 01:19:42]

dalecurtis@ PTAL

(plz see for context the linked Intent To Ship)

CC: esprehn@, miguelg@ and rbyers@

[DaleCurtis, 2015-12-01 01:23:57]

Presumably this is all still behind a runtime flag? As I don't see any approvals
on the intent to ship.

[mcasas, 2015-12-01 01:29:09]

On 2015/12/01 01:23:57, DaleCurtis wrote:
> Presumably this is all still behind a runtime flag? As I don't see any
approvals
> on the intent to ship.

Yes, is still behind a Web Experimental flag [1]. The point
of this CL is to prove that MSR can be be implemented in
Android, notwithstanding the "size matters" issue. IOW,
for ITS LGTM, we need Android working, and we need
Android working for an ITS LGTM. Deadlock! I'll let you
decide which one should be unlocked first :)


[1]
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[DaleCurtis, 2015-12-01 01:32:31]

I don't think that's how this works :) Can you confirm that this works for you
locally on Android? Otherwise it feels like this should be held off until you
have verified that.

[Rick Byers, 2015-12-01 17:28:20]

On 2015/12/01 01:29:09, mcasas wrote:
> On 2015/12/01 01:23:57, DaleCurtis wrote:
> > Presumably this is all still behind a runtime flag? As I don't see any
> approvals
> > on the intent to ship.
> 
> Yes, is still behind a Web Experimental flag [1]. The point
> of this CL is to prove that MSR can be be implemented in
> Android, notwithstanding the "size matters" issue. IOW,
> for ITS LGTM, we need Android working, and we need
> Android working for an ITS LGTM. Deadlock! I'll let you
> decide which one should be unlocked first :)

Having Android working in trunk isn't necessary for the ITS LGTM IMHO.  As long
as there is agreement that we'll ship on all platforms simultaneously, that's
good enough (at least for me).

> 
> 
> [1]
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[mcasas, 2015-12-01 18:18:22]

Patchset #3 (id:120001) has been deleted

[mcasas, 2015-12-01 18:35:52]

Description was changed from

==========
MediaStreamRecorder: enable in Android (including linking libwebm)

This follows a conversation in the Intent-To-Ship [1].

The added code means: 
- third_party/libwebm
- media::WebmMuxer
- content::AudioTrackRecorder
- content::VideoTrackRecorder
- content::MediaRecorderHandler.

third_party/libwebm size: 10154B

Increase in ChromePublic-unsigned.apk:
54673026 - 54651438 = 21588B ~= 21KB

----- Note: 
Modified code in webm_muxer.cc due to complaint from
arm-linux-androideabi-4.9:
../../media/capture/webm_muxer.cc:49:76: error: array subscript is above array
bounds [-Werror=array-bounds]
            kOpusVorbisChannelMap[params.channels() - 1], params.channels());
------


BUG=262211, 561068

[1]
https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/LtZYZWvV...
==========

to

==========
MediaStreamRecorder: enable in Android (including linking libwebm)

This follows a conversation in the Intent-To-Ship [1].

The added code means: 
- third_party/libwebm
- media::WebmMuxer
- content::AudioTrackRecorder
- content::VideoTrackRecorder
- content::MediaRecorderHandler.

third_party/libwebm size: 10154B

Increase in ChromePublic-unsigned.apk:
54673026 - 54651438 = 21588B ~= 21KB

----- Note: 
Modified code in webm_muxer.cc due to complaint from
arm-linux-androideabi-4.9:
../../media/capture/webm_muxer.cc:49:76: error: array subscript is above array
bounds [-Werror=array-bounds]
            kOpusVorbisChannelMap[params.channels() - 1], params.channels());
------

BUG=262211, 561068

TEST=Same as for desktop platform:
https://rawgit.com/Miguelao/demos/master/mediarcorder.html
Results of running it can be found under [2] and [3]

[1]
https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/LtZYZWvV...
[2]
https://drive.google.com/file/d/0B82Jhdx0kSTVS3E4bFZwZUxSSTQ/view?usp=sharing
[3]
https://drive.google.com/file/d/0B82Jhdx0kSTVM3lfR2N0RFlwNzg/view?usp=sharing
==========

[mcasas, 2015-12-01 18:38:15]

PS3 added a missing piece that was overlooked by the
careless developer of this CL. Added TEST= section with
screen recordings of the test run.
PTAL!

[DaleCurtis, 2015-12-01 18:39:31]

I think before a CL titled enable in Android is landed, at least some
confirmation of the current state on said platform should be included :) mcasas@
verified it is working, so lgtm

[mcasas, 2015-12-01 19:50:45]

mcasas@chromium.org changed reviewers:
+ avi@chromium.org

[mcasas, 2015-12-01 19:50:45]

avi@ RS for 
content/renderer/BUILD.gn
content/renderer/renderer_blink_platform_impl.cc

(basically removing #ifdef(OS_ANDROID) parts)

[Avi (use Gerrit), 2015-12-01 20:56:11]

lgtm

stampity stamp

[mcasas, 2015-12-01 22:04:59]

Description was changed from

==========
MediaStreamRecorder: enable in Android (including linking libwebm)

This follows a conversation in the Intent-To-Ship [1].

The added code means: 
- third_party/libwebm
- media::WebmMuxer
- content::AudioTrackRecorder
- content::VideoTrackRecorder
- content::MediaRecorderHandler.

third_party/libwebm size: 10154B

Increase in ChromePublic-unsigned.apk:
54673026 - 54651438 = 21588B ~= 21KB

----- Note: 
Modified code in webm_muxer.cc due to complaint from
arm-linux-androideabi-4.9:
../../media/capture/webm_muxer.cc:49:76: error: array subscript is above array
bounds [-Werror=array-bounds]
            kOpusVorbisChannelMap[params.channels() - 1], params.channels());
------

BUG=262211, 561068

TEST=Same as for desktop platform:
https://rawgit.com/Miguelao/demos/master/mediarcorder.html
Results of running it can be found under [2] and [3]

[1]
https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/LtZYZWvV...
[2]
https://drive.google.com/file/d/0B82Jhdx0kSTVS3E4bFZwZUxSSTQ/view?usp=sharing
[3]
https://drive.google.com/file/d/0B82Jhdx0kSTVM3lfR2N0RFlwNzg/view?usp=sharing
==========

to

==========
MediaStreamRecorder: enable in Android (including linking libwebm)

This follows a conversation in the Intent-To-Ship [1].

The added code means: 
- third_party/libwebm
- media::WebmMuxer
- content::AudioTrackRecorder
- content::VideoTrackRecorder
- content::MediaRecorderHandler.

third_party/libwebm size: 10154B

Increase in ChromePublic-unsigned.apk:
54673026 - 54651438 = 21588B ~= 21KB

----- Note: 
Modified code in webm_muxer.cc due to complaint from
arm-linux-androideabi-4.9:
../../media/capture/webm_muxer.cc:49:76: error: array subscript is above array
bounds [-Werror=array-bounds]
            kOpusVorbisChannelMap[params.channels() - 1], params.channels());
------

BUG=262211, 561068

TEST=Same as for desktop platform:
https://rawgit.com/Miguelao/demos/master/mediarecorder.html
Results of running it can be found under [2] and [3]

[1]
https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/LtZYZWvV...
[2]
https://drive.google.com/file/d/0B82Jhdx0kSTVS3E4bFZwZUxSSTQ/view?usp=sharing
[3]
https://drive.google.com/file/d/0B82Jhdx0kSTVM3lfR2N0RFlwNzg/view?usp=sharing
==========

[mcasas, 2015-12-01 22:09:09]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2015-12-01 22:09:09]

The patchset sent to the CQ was uploaded after l-g-t-m from rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/1486623004/#ps140001
(title: "Connect RendererBlinkPlatformImpl::createMediaRecorderHandler()")

[commit-bot: I haz the power, 2015-12-01 22:12:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1486623004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1486623004/140001

[commit-bot: I haz the power, 2015-12-01 22:42:24]

Description was changed from

==========
MediaStreamRecorder: enable in Android (including linking libwebm)

This follows a conversation in the Intent-To-Ship [1].

The added code means: 
- third_party/libwebm
- media::WebmMuxer
- content::AudioTrackRecorder
- content::VideoTrackRecorder
- content::MediaRecorderHandler.

third_party/libwebm size: 10154B

Increase in ChromePublic-unsigned.apk:
54673026 - 54651438 = 21588B ~= 21KB

----- Note: 
Modified code in webm_muxer.cc due to complaint from
arm-linux-androideabi-4.9:
../../media/capture/webm_muxer.cc:49:76: error: array subscript is above array
bounds [-Werror=array-bounds]
            kOpusVorbisChannelMap[params.channels() - 1], params.channels());
------

BUG=262211, 561068

TEST=Same as for desktop platform:
https://rawgit.com/Miguelao/demos/master/mediarecorder.html
Results of running it can be found under [2] and [3]

[1]
https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/LtZYZWvV...
[2]
https://drive.google.com/file/d/0B82Jhdx0kSTVS3E4bFZwZUxSSTQ/view?usp=sharing
[3]
https://drive.google.com/file/d/0B82Jhdx0kSTVM3lfR2N0RFlwNzg/view?usp=sharing
==========

to

==========
MediaStreamRecorder: enable in Android (including linking libwebm)

This follows a conversation in the Intent-To-Ship [1].

The added code means: 
- third_party/libwebm
- media::WebmMuxer
- content::AudioTrackRecorder
- content::VideoTrackRecorder
- content::MediaRecorderHandler.

third_party/libwebm size: 10154B

Increase in ChromePublic-unsigned.apk:
54673026 - 54651438 = 21588B ~= 21KB

----- Note: 
Modified code in webm_muxer.cc due to complaint from
arm-linux-androideabi-4.9:
../../media/capture/webm_muxer.cc:49:76: error: array subscript is above array
bounds [-Werror=array-bounds]
            kOpusVorbisChannelMap[params.channels() - 1], params.channels());
------

BUG=262211, 561068

TEST=Same as for desktop platform:
https://rawgit.com/Miguelao/demos/master/mediarecorder.html
Results of running it can be found under [2] and [3]

[1]
https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/LtZYZWvV...
[2]
https://drive.google.com/file/d/0B82Jhdx0kSTVS3E4bFZwZUxSSTQ/view?usp=sharing
[3]
https://drive.google.com/file/d/0B82Jhdx0kSTVM3lfR2N0RFlwNzg/view?usp=sharing
==========

[commit-bot: I haz the power, 2015-12-01 22:42:26]

Committed patchset #3 (id:140001)

[commit-bot: I haz the power, 2015-12-01 22:44:23]

Description was changed from

==========
MediaStreamRecorder: enable in Android (including linking libwebm)

This follows a conversation in the Intent-To-Ship [1].

The added code means: 
- third_party/libwebm
- media::WebmMuxer
- content::AudioTrackRecorder
- content::VideoTrackRecorder
- content::MediaRecorderHandler.

third_party/libwebm size: 10154B

Increase in ChromePublic-unsigned.apk:
54673026 - 54651438 = 21588B ~= 21KB

----- Note: 
Modified code in webm_muxer.cc due to complaint from
arm-linux-androideabi-4.9:
../../media/capture/webm_muxer.cc:49:76: error: array subscript is above array
bounds [-Werror=array-bounds]
            kOpusVorbisChannelMap[params.channels() - 1], params.channels());
------

BUG=262211, 561068

TEST=Same as for desktop platform:
https://rawgit.com/Miguelao/demos/master/mediarecorder.html
Results of running it can be found under [2] and [3]

[1]
https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/LtZYZWvV...
[2]
https://drive.google.com/file/d/0B82Jhdx0kSTVS3E4bFZwZUxSSTQ/view?usp=sharing
[3]
https://drive.google.com/file/d/0B82Jhdx0kSTVM3lfR2N0RFlwNzg/view?usp=sharing
==========

to

==========
MediaStreamRecorder: enable in Android (including linking libwebm)

This follows a conversation in the Intent-To-Ship [1].

The added code means:
- third_party/libwebm
- media::WebmMuxer
- content::AudioTrackRecorder
- content::VideoTrackRecorder
- content::MediaRecorderHandler.

third_party/libwebm size: 10154B

Increase in ChromePublic-unsigned.apk:
54673026 - 54651438 = 21588B ~= 21KB

----- Note:
Modified code in webm_muxer.cc due to complaint from
arm-linux-androideabi-4.9:
../../media/capture/webm_muxer.cc:49:76: error: array subscript is above array
bounds [-Werror=array-bounds]
            kOpusVorbisChannelMap[params.channels() - 1], params.channels());
------

BUG=262211, 561068

TEST=Same as for desktop platform:
https://rawgit.com/Miguelao/demos/master/mediarecorder.html
Results of running it can be found under [2] and [3]

[1]
https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/LtZYZWvV...
[2]
https://drive.google.com/file/d/0B82Jhdx0kSTVS3E4bFZwZUxSSTQ/view?usp=sharing
[3]
https://drive.google.com/file/d/0B82Jhdx0kSTVM3lfR2N0RFlwNzg/view?usp=sharing

Committed: https://crrev.com/f683b07078e7fba476ef33625b0b41fd6161772c
Cr-Commit-Position: refs/heads/master@{#362536}
==========

[commit-bot: I haz the power, 2015-12-01 22:44:24]

Patchset 3 (id:??) landed as
https://crrev.com/f683b07078e7fba476ef33625b0b41fd6161772c
Cr-Commit-Position: refs/heads/master@{#362536}