Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1486623003:
Re-land: chrome: Add support for use_glib=true to wayland server. (Closed)
|
Created:
5 years ago by reveman Modified:
4 years, 10 months ago Reviewers:
jochen (gone - plz use gerrit) CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRe-land: chrome: Add support for use_glib=true to wayland server.
This adds a GLib WaylandWatcher implemenatation that allows the
Wayland server to listen for and dispatch messages when using a
GLib message loop.
BUG=549781
TEST=build chrome without use_glib=false and run with --enable-wayland-server
Committed: https://crrev.com/9351cf6ed4e3aad16886bdadbad328b0df50f508
Cr-Commit-Position: refs/heads/master@{#374915}
Patch Set 1 #
Total comments: 2
Patch Set 2 : align gyp and GN #
Total comments: 2
Patch Set 3 : fix shutdown issue #
Messages
Total messages: 27 (11 generated)
The CQ bit was checked by reveman@chromium.org to run a CQ dry run
reveman@chromium.org changed reviewers: + jochen@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486623003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/1486623003/diff/1/build/config/ui.gni File build/config/ui.gni (left): https://codereview.chromium.org/1486623003/diff/1/build/config/ui.gni#oldcode73 build/config/ui.gni:73: if (use_glib) { where's the corresponding gypi change?
ptal https://codereview.chromium.org/1486623003/diff/1/build/config/ui.gni File build/config/ui.gni (left): https://codereview.chromium.org/1486623003/diff/1/build/config/ui.gni#oldcode73 build/config/ui.gni:73: if (use_glib) { On 2015/12/01 at 13:45:22, jochen wrote: > where's the corresponding gypi change? Gyp build didn't force enable_wayland_server to 0 when use_glib=1. Gyp build just enabled wayland_server if 'chromeos==1 and use_ozone==1', which implied use_glib=0 by default and you could always override it if you knew what you were doing. https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&... The main reason this was different is because how we set use_glib=false in GN build files. Now that use_glib doesn't matter anymore, GN and gyp configs can easily have matching logic. I updated latest patch to simply set enable_wayland_server to true by default when chromeos=1 for both GN and gyp. https://codereview.chromium.org/1486623003/diff/20001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/1486623003/diff/20001/build/common.gypi#newco... build/common.gypi:762: ['chromeos==1', { Fyi, here is where enable_wayland_server is set to a default value when using gyp. https://codereview.chromium.org/1486623003/diff/20001/build/config/ui.gni File build/config/ui.gni (right): https://codereview.chromium.org/1486623003/diff/20001/build/config/ui.gni#new... build/config/ui.gni:51: enable_wayland_server = is_chromeos Fyi, here is where enable_wayland_server is set to a default value when using GN.
The CQ bit was checked by reveman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486623003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486623003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by reveman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486623003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486623003/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== chrome: Add support for use_glib=true to wayland server. This adds a GLib WaylandWatcher implemenatation that allows the Wayland server to listen for and dispatch messages when using a GLib message loop. BUG=549781 TEST=build chrome without use_glib=false and run with --enable-wayland-server ========== to ========== chrome: Add support for use_glib=true to wayland server. This adds a GLib WaylandWatcher implemenatation that allows the Wayland server to listen for and dispatch messages when using a GLib message loop. BUG=549781 TEST=build chrome without use_glib=false and run with --enable-wayland-server Committed: https://crrev.com/75cd05b4694653d9af4fcc8c5c05f7dae433137d Cr-Commit-Position: refs/heads/master@{#362719} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/75cd05b4694653d9af4fcc8c5c05f7dae433137d Cr-Commit-Position: refs/heads/master@{#362719}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1499253002/ by stevenjb@chromium.org. The reason for reverting is: crbug.com/566152 .
Description was changed from ========== chrome: Add support for use_glib=true to wayland server. This adds a GLib WaylandWatcher implemenatation that allows the Wayland server to listen for and dispatch messages when using a GLib message loop. BUG=549781 TEST=build chrome without use_glib=false and run with --enable-wayland-server Committed: https://crrev.com/75cd05b4694653d9af4fcc8c5c05f7dae433137d Cr-Commit-Position: refs/heads/master@{#362719} ========== to ========== Re-land: chrome: Add support for use_glib=true to wayland server. This adds a GLib WaylandWatcher implemenatation that allows the Wayland server to listen for and dispatch messages when using a GLib message loop. BUG=549781 TEST=build chrome without use_glib=false and run with --enable-wayland-server ==========
The CQ bit was checked by reveman@chromium.org
This was causing shutdown issues as WaylandSourceCheck was always returning true. Fixed in latest patch so I'll try to re-land this now.
The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org Link to the patchset: https://codereview.chromium.org/1486623003/#ps40001 (title: "fix shutdown issue")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486623003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486623003/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Re-land: chrome: Add support for use_glib=true to wayland server. This adds a GLib WaylandWatcher implemenatation that allows the Wayland server to listen for and dispatch messages when using a GLib message loop. BUG=549781 TEST=build chrome without use_glib=false and run with --enable-wayland-server ========== to ========== Re-land: chrome: Add support for use_glib=true to wayland server. This adds a GLib WaylandWatcher implemenatation that allows the Wayland server to listen for and dispatch messages when using a GLib message loop. BUG=549781 TEST=build chrome without use_glib=false and run with --enable-wayland-server Committed: https://crrev.com/9351cf6ed4e3aad16886bdadbad328b0df50f508 Cr-Commit-Position: refs/heads/master@{#374915} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/9351cf6ed4e3aad16886bdadbad328b0df50f508 Cr-Commit-Position: refs/heads/master@{#374915} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
