Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1486613002: [turbofan]: No tabs in tokens in JSON graph files (ECMA404 compliance). (Closed)

Created:
5 years ago by oth
Modified:
5 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan]: No tabs in tokens in JSON graph files (ECMA404 compliance). BUG= LOG=N Committed: https://crrev.com/b0cf04535ed6aaea9d1479079de263441f79bcc9 Cr-Commit-Position: refs/heads/master@{#32411}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/ostreams.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
oth
Michi, PTAL. This is a one-line fix for a missing case for tabs in AsEscapedUC16ForJSON. ...
5 years ago (2015-11-30 14:53:06 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486613002/1
5 years ago (2015-11-30 15:45:01 UTC) #4
Michael Starzinger
LGTM.
5 years ago (2015-11-30 15:54:50 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-30 16:11:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486613002/1
5 years ago (2015-11-30 16:41:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 16:43:46 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-30 16:44:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0cf04535ed6aaea9d1479079de263441f79bcc9
Cr-Commit-Position: refs/heads/master@{#32411}

Powered by Google App Engine
This is Rietveld 408576698