Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1486593003: shell_util: Minor tweaks to comments that didn't land in previous CL. (Closed)

Created:
5 years ago by Matt Giuca
Modified:
5 years ago
Reviewers:
gab
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@shell_util-registryentry-public-ctors
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

shell_util: Minor tweaks to comments that didn't land in previous CL. BUG=419972 Committed: https://crrev.com/d59361bcb4e0a8ecd6985eb6865b53f8bbad0193 Cr-Commit-Position: refs/heads/master@{#362514}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/installer/util/shell_util.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 1486493002 Patch 1

Dependent Patchsets:

Issue 1486513002 Patch 60001

Messages

Total messages: 8 (3 generated)
Matt Giuca
5 years ago (2015-12-01 00:47:36 UTC) #2
gab
lgtm, thanks -- sorry I hit the CQ despite the nits looks like (not unintentional, ...
5 years ago (2015-12-01 20:13:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486593003/1
5 years ago (2015-12-01 20:14:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 21:53:20 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-01 21:55:40 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d59361bcb4e0a8ecd6985eb6865b53f8bbad0193
Cr-Commit-Position: refs/heads/master@{#362514}

Powered by Google App Engine
This is Rietveld 408576698