Fix the issue that no response from the call back function of FFI_GetPlatform()

Fix the issue that no response from the call back function of FFI_GetPlatform()

BUG=pdfium:293
R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/a0217b66d6fb4980bff16167093bc2a79f71bcec

[jun_fang, 2015-11-30 09:48:44]

jun_fang@foxitsoftware.com changed reviewers:
+ kai_jing@foxitsoftware.com, thestig@chromium.org, tsepez@chromium.org

[jun_fang, 2015-11-30 09:48:45]

Hi Tom and Lei,

Please help to review this CL. Thanks!

[Tom Sepez, 2015-11-30 17:17:33]

https://codereview.chromium.org/1486583002/diff/1/fpdfsdk/src/javascript/app.cpp
File fpdfsdk/src/javascript/app.cpp (right):

https://codereview.chromium.org/1486583002/diff/1/fpdfsdk/src/javascript/app....
fpdfsdk/src/javascript/app.cpp:223: if (!pContext)
Can these ever be NULL?

[jun_fang, 2015-12-01 10:53:30]

https://codereview.chromium.org/1486583002/diff/1/fpdfsdk/src/javascript/app.cpp
File fpdfsdk/src/javascript/app.cpp (right):

https://codereview.chromium.org/1486583002/diff/1/fpdfsdk/src/javascript/app....
fpdfsdk/src/javascript/app.cpp:223: if (!pContext)
pContext is passed from v8. It shouldn't be nullptr.

https://codereview.chromium.org/1486583002/diff/1/fpdfsdk/src/javascript/app....
fpdfsdk/src/javascript/app.cpp:226: if (!pRuntime)
pRuntime shouldn't be nullptr either.

https://codereview.chromium.org/1486583002/diff/1/fpdfsdk/src/javascript/app....
fpdfsdk/src/javascript/app.cpp:229: if (!pEnv)
pEnv can be nullptr.

[jun_fang, 2015-12-01 10:53:58]

On 2015/12/01 10:53:30, jun_fang wrote:
>
https://codereview.chromium.org/1486583002/diff/1/fpdfsdk/src/javascript/app.cpp
> File fpdfsdk/src/javascript/app.cpp (right):
> 
>
https://codereview.chromium.org/1486583002/diff/1/fpdfsdk/src/javascript/app....
> fpdfsdk/src/javascript/app.cpp:223: if (!pContext)
> pContext is passed from v8. It shouldn't be nullptr.
> 
>
https://codereview.chromium.org/1486583002/diff/1/fpdfsdk/src/javascript/app....
> fpdfsdk/src/javascript/app.cpp:226: if (!pRuntime)
> pRuntime shouldn't be nullptr either.
> 
>
https://codereview.chromium.org/1486583002/diff/1/fpdfsdk/src/javascript/app....
> fpdfsdk/src/javascript/app.cpp:229: if (!pEnv)
> pEnv can be nullptr.

Please review patch 2.

[Tom Sepez, 2015-12-01 17:21:48]

lgtm

[jun_fang, 2015-12-02 05:57:26]

Description was changed from

==========
Fix the issue that no response from the call back function of FFI_GetPlatform()

BUG=pdfium:293
==========

to

==========
Fix the issue that no response from the call back function of FFI_GetPlatform()

BUG=pdfium:293
R=tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/a0217b66d6fb4980bff16167093bc2a79f71...
==========

[jun_fang, 2015-12-02 05:57:29]

Committed patchset #2 (id:20001) manually as
a0217b66d6fb4980bff16167093bc2a79f71bcec (presubmit successful).