Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1486573003: Mojo C++ bindings: associated interface pointers/requests validation (Closed)

Created:
5 years ago by yzshen1
Modified:
5 years ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: associated interface pointers/requests validation This CL also moves some validation code from code generation template to C++, in order to improve readability. BUG=546067 Committed: https://crrev.com/da11133fa64a17af7a10d501dae42ce6ba83fe63 Cr-Commit-Position: refs/heads/master@{#362548}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -43 lines) Patch
M mojo/public/cpp/bindings/lib/bindings_internal.h View 1 chunk +1 line, -4 lines 0 comments Download
M mojo/public/cpp/bindings/lib/validation_errors.h View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/validation_errors.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/validation_util.h View 1 2 chunks +77 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/validation_util.cc View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/validation_unittest.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/associated_conformance_mthd0_good.data View 1 chunk +13 lines, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/associated_conformance_mthd0_good.expected View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/associated_conformance_mthd0_unexpected_invalid_associated_interface.data View 1 chunk +14 lines, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/associated_conformance_mthd0_unexpected_invalid_associated_interface.expected View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/associated_conformance_mthd1_good.data View 1 chunk +13 lines, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/associated_conformance_mthd1_good.expected View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/associated_conformance_mthd1_unexpected_invalid_associated_request.data View 1 chunk +14 lines, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/associated_conformance_mthd1_unexpected_invalid_associated_request.expected View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/associated_conformance_mthd2_master_interface_id.data View 1 chunk +15 lines, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/associated_conformance_mthd2_master_interface_id.expected View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/validation_test_associated_interfaces.mojom View 1 chunk +17 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl View 2 chunks +41 lines, -39 lines 0 comments Download
M third_party/mojo/mojo_public.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
yzshen1
Hi, Scott. Would you please take a look? Thanks!
5 years ago (2015-12-01 16:44:31 UTC) #2
sky
LGTM
5 years ago (2015-12-01 21:22:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486573003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486573003/40001
5 years ago (2015-12-01 21:55:27 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-01 23:50:51 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-01 23:52:52 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/da11133fa64a17af7a10d501dae42ce6ba83fe63
Cr-Commit-Position: refs/heads/master@{#362548}

Powered by Google App Engine
This is Rietveld 408576698