Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1486563002: Remove {FIRST,LAST}_SPEC_OBJECT_TYPE. (Closed)

Created:
5 years ago by neis
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove {FIRST,LAST}_SPEC_OBJECT_TYPE. Use {FIRST,LAST}_JS_RECEIVER_TYPE instead. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/18ee425cb49130ec65d261230be1413d4ee49d54 Cr-Commit-Position: refs/heads/master@{#32393}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -277 lines) Patch
M src/arm/builtins-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 5 chunks +11 lines, -11 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 5 chunks +11 lines, -11 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 7 chunks +12 lines, -12 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 7 chunks +12 lines, -12 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ppc/handler-compiler-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/builtins-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M src/objects.h View 2 chunks +2 lines, -6 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/builtins-ppc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M src/runtime/runtime-interpreter.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M src/x87/builtins-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 5 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
neis
5 years ago (2015-11-30 08:44:14 UTC) #1
Benedikt Meurer
LGTM, thanks.
5 years ago (2015-11-30 09:18:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486563002/1
5 years ago (2015-11-30 09:18:48 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 09:49:25 UTC) #5
commit-bot: I haz the power
5 years ago (2015-11-30 09:50:12 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/18ee425cb49130ec65d261230be1413d4ee49d54
Cr-Commit-Position: refs/heads/master@{#32393}

Powered by Google App Engine
This is Rietveld 408576698