Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1486553002: [proxies] Use IsRevoked where possible, remove has_handler. (Closed)

Created:
5 years ago by neis
Modified:
5 years ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[proxies] Use IsRevoked where possible, remove has_handler. R=jkummerow@chromium.org BUG= Committed: https://crrev.com/39296e679fc4d760087db784397a1ab93e92a5f4 Cr-Commit-Position: refs/heads/master@{#32394}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -40 lines) Patch
M src/messages.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects.h View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M src/objects.cc View 1 2 12 chunks +26 lines, -28 lines 0 comments Download
M src/objects-inl.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-proxy.cc View 1 chunk +3 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
neis
5 years ago (2015-11-30 08:11:01 UTC) #1
Jakob Kummerow
LGTM with comment. https://codereview.chromium.org/1486553002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1486553002/diff/1/src/objects.cc#newcode6921 src/objects.cc:6921: Handle<JSProxy> proxy = Handle<JSProxy>::cast(it->GetHolder<Object>()); unnecessary double ...
5 years ago (2015-11-30 08:47:55 UTC) #2
neis
https://codereview.chromium.org/1486553002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1486553002/diff/1/src/objects.cc#newcode6921 src/objects.cc:6921: Handle<JSProxy> proxy = Handle<JSProxy>::cast(it->GetHolder<Object>()); On 2015/11/30 08:47:55, Jakob wrote: ...
5 years ago (2015-11-30 09:17:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486553002/20001
5 years ago (2015-11-30 09:18:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/34)
5 years ago (2015-11-30 09:25:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486553002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486553002/40001
5 years ago (2015-11-30 09:37:20 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-30 09:59:24 UTC) #12
commit-bot: I haz the power
5 years ago (2015-11-30 10:00:00 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/39296e679fc4d760087db784397a1ab93e92a5f4
Cr-Commit-Position: refs/heads/master@{#32394}

Powered by Google App Engine
This is Rietveld 408576698