Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 148653002: Revert of Unwrap GrRedBlackTree unit test and use REPORTER_ASSERT(). (Closed)

Created:
6 years, 11 months ago by epoger
Modified:
6 years, 11 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Revert of Unwrap GrRedBlackTree unit test and use REPORTER_ASSERT(). (https://codereview.chromium.org/147713002/) Reason for revert: broke http://108.170.217.252:10115/builders/Build-Mac10.8-Clang-x86_64-Release/builds/2908/steps/Retry_BuildTests/logs/stdio and other builders: GrRedBlackTreeTest.cpp:24:36: error: use of undeclared identifier 'xi' Original issue's description: > Unwrap GrRedBlackTree unit test and use REPORTER_ASSERT(). > > This fixes the mtklein's TODO in GrUnitTests.cpp. > > BUG=None > TEST=out/Debug/tests > R=mtklein@google.com, robertphillips@google.com > > Committed: https://code.google.com/p/skia/source/detail?r=13208 TBR=mtklein@google.com,robertphillips@google.com,reed@google.com,tfarina@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Committed: http://code.google.com/p/skia/source/detail?r=13209

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -184 lines) Patch
M gyp/tests.gyp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/gpu/GrRedBlackTree.h View 2 chunks +171 lines, -1 line 0 comments Download
D tests/GrRedBlackTreeTest.cpp View 1 chunk +0 lines, -180 lines 0 comments Download
M tests/GrUnitTests.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
epoger
Created Revert of Unwrap GrRedBlackTree unit test and use REPORTER_ASSERT().
6 years, 11 months ago (2014-01-27 21:53:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/148653002/1
6 years, 11 months ago (2014-01-27 21:54:00 UTC) #2
commit-bot: I haz the power
6 years, 11 months ago (2014-01-27 21:54:33 UTC) #3
Message was sent while issue was closed.
Change committed as 13209

Powered by Google App Engine
This is Rietveld 408576698