Draw the caps lock indicator manually, rather than using WKDrawCapsLockIndicator.

Draw the caps lock indicator manually, rather than using WKDrawCapsLockIndicator.

BUG=101156
R=thakis@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149652

[Robert Sesek, 2013-05-02 20:08:15]

I know it's rather magic numbery but it produces identical output.

[Nico, 2013-05-02 20:57:13]

minor comment below, but it basically lgtm. i'll patch this in and check if it
looks good on retina.

Looks like we don't implement this on the other platforms – we probably should.
Can you file a bug for that?

https://codereview.chromium.org/14865002/diff/3001/Source/core/rendering/Rend...
File Source/core/rendering/RenderThemeChromiumMac.mm (right):

https://codereview.chromium.org/14865002/diff/3001/Source/core/rendering/Rend...
Source/core/rendering/RenderThemeChromiumMac.mm:774: 
Can you add a comment like

// Matches the appearance of what SPI WKDrawCapsLockIndicator() would draw.

?

https://codereview.chromium.org/14865002/diff/3001/Source/core/rendering/Rend...
Source/core/rendering/RenderThemeChromiumMac.mm:776: CGContextSaveGState(c);
.cgContext() returns a fresh context, so you probably don't need to save /
restore state

[Robert Sesek, 2013-05-02 21:07:25]

Filed http://crbug.com/237624

https://codereview.chromium.org/14865002/diff/3001/Source/core/rendering/Rend...
File Source/core/rendering/RenderThemeChromiumMac.mm (right):

https://codereview.chromium.org/14865002/diff/3001/Source/core/rendering/Rend...
Source/core/rendering/RenderThemeChromiumMac.mm:774: 
On 2013/05/02 20:57:13, Nico wrote:
> Can you add a comment like
> 
> // Matches the appearance of what SPI WKDrawCapsLockIndicator() would draw.
> 
> ?

Done.

https://codereview.chromium.org/14865002/diff/3001/Source/core/rendering/Rend...
Source/core/rendering/RenderThemeChromiumMac.mm:776: CGContextSaveGState(c);
On 2013/05/02 20:57:13, Nico wrote:
> .cgContext() returns a fresh context, so you probably don't need to save /
> restore state

Done.

[Nico, 2013-05-02 22:02:10]

Looks good on retina. Sorry about the delay, had to do a full build.

[Robert Sesek, 2013-05-02 23:14:19]

On 2013/05/02 22:02:10, Nico wrote:
> Looks good on retina. Sorry about the delay, had to do a full build.

Thanks for checking!

[Robert Sesek, 2013-05-03 15:10:48]

Committed patchset #3 manually as r149652 (presubmit successful).