Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1486483003: X87: [TurboFan] enable the Float64RoundDown and Float64RoundTruncate operators in x87. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [TurboFan] enable the Float64RoundDown and Float64RoundTruncate operators in x87. X87 port already implemented Float64RoundDown and Float64RoundTruncate operators, not enabled yet. This CL would enable them. BUG= Committed: https://crrev.com/da566d89050d8af26cf5c619493eab6fdd745c2e Cr-Commit-Position: refs/heads/master@{#32442}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
5 years ago (2015-11-30 07:20:43 UTC) #2
Weiliang
lgtm
5 years ago (2015-12-01 06:31:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486483003/1
5 years ago (2015-12-01 06:31:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 06:47:47 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-01 06:48:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da566d89050d8af26cf5c619493eab6fdd745c2e
Cr-Commit-Position: refs/heads/master@{#32442}

Powered by Google App Engine
This is Rietveld 408576698