Convert dart_utils.js to input_sdk/lib/_internal/utils.dart (#310)

tool/sdk_expected_errors.txt

Index: tool/sdk_expected_errors.txt
diff --git a/tool/sdk_expected_errors.txt b/tool/sdk_expected_errors.txt
index ca6d037e7feaba5697f83935c85903020e89f5c0..3986138078d4f1e2ff1709152106f137311f328e 100644
--- a/tool/sdk_expected_errors.txt
+++ b/tool/sdk_expected_errors.txt
@@ -1,8 +1,20 @@
 severe: [AnalyzerMessage] The redirected constructor '(dynamic) → JSArray<dynamic>' has incompatible parameters with '(dynamic) → JSArray<E>' (dart:_interceptors/js_array.dart, line 29, col 46)
 severe: [AnalyzerMessage] Missing concrete implementation of 'num.==' (dart:_interceptors/js_number.dart, line 12, col 7)
 severe: [AnalyzerMessage] Missing concrete implementation of 'String.==' (dart:_interceptors/js_string.dart, line 14, col 7)
+severe: [AnalyzerMessage] 'const' variables must be constant value (dart:_utils, line 12, col 24)
+severe: [AnalyzerMessage] 'const' variables must be constant value (dart:_utils, line 13, col 34)
+severe: [AnalyzerMessage] 'const' variables must be constant value (dart:_utils, line 14, col 29)
+severe: [AnalyzerMessage] 'const' variables must be constant value (dart:_utils, line 15, col 31)
+severe: [AnalyzerMessage] 'const' variables must be constant value (dart:_utils, line 17, col 24)
+severe: [AnalyzerMessage] 'const' variables must be constant value (dart:_utils, line 20, col 25)
 severe: [AnalyzerMessage] The redirected constructor '((Stream<dynamic>, bool) → StreamSubscription<dynamic>) → _StreamSubscriptionTransformer<dynamic, dynamic>' has incompatible parameters with '((Stream<S>, bool) → StreamSubscription<T>) → StreamTransformer<S, T>' (dart:async/stream.dart, line 1571, col 9)
 severe: [AnalyzerMessage] The redirected constructor '({handleData: (dynamic, EventSink<dynamic>) → void, handleError: (Object, StackTrace, EventSink<dynamic>) → void, handleDone: (EventSink<dynamic>) → void}) → _StreamHandlerTransformer<dynamic, dynamic>' has incompatible parameters with '({handleData: (S, EventSink<T>) → void, handleError: (Object, StackTrace, EventSink<T>) → void, handleDone: (EventSink<T>) → void}) → StreamTransformer<S, T>' (dart:async/stream.dart, line 1588, col 13)
+severe: [AnalyzerMessage] The type '_NoCallbackSyncStreamController' is declared with 0 type parameters, but 1 type arguments were given (dart:async/stream_controller.dart, line 84, col 17)
+severe: [AnalyzerMessage] The type '_NoCallbackAsyncStreamController' is declared with 0 type parameters, but 1 type arguments were given (dart:async/stream_controller.dart, line 85, col 17)
+severe: [AnalyzerMessage] The name 'T' is not a type and cannot be used as a parameterized type (dart:async/stream_controller.dart, line 653, col 69)
+severe: [AnalyzerMessage] The name 'T' is not a type and cannot be used as a parameterized type (dart:async/stream_controller.dart, line 654, col 46)
+severe: [AnalyzerMessage] The name 'T' is not a type and cannot be used as a parameterized type (dart:async/stream_controller.dart, line 656, col 68)
+severe: [AnalyzerMessage] The name 'T' is not a type and cannot be used as a parameterized type (dart:async/stream_controller.dart, line 657, col 45)
 severe: [AnalyzerMessage] The redirected constructor '((List<dynamic>) → void) → _SimpleCallbackSink<dynamic>' has incompatible parameters with '((List<T>) → void) → ChunkedConversionSink<T>' (dart:convert/chunked_conversion.dart, line 23, col 45)
 severe: [AnalyzerMessage] The redirected constructor '(Iterable<E>) → LinkedHashSet<E>' has incompatible parameters with '(Iterable<dynamic>) → Set<E>' (dart:core/set.dart, line 75, col 41)
 warning: [DownCastComposite] doneHandlers (dynamic) will need runtime check to cast to type Iterable<SendPort> (dart:_isolate_helper, line 574, col 29)
@@ -65,7 +77,7 @@ warning: [DownCastComposite] timeout2 (Function) will need runtime check to cast
 warning: [DownCastComposite] zone.registerUnaryCallback(onTimeout) ((dynamic) → dynamic) will need runtime check to cast to type (EventSink<dynamic>) → void (dart:async/stream.dart, line 1246, col 21)
 warning: [DownCastComposite] timeout2 (Function) will need runtime check to cast to type () → void (dart:async/stream.dart, line 1257, col 43)
 warning: [DownCastComposite] timeout2 (Function) will need runtime check to cast to type () → void (dart:async/stream.dart, line 1276, col 53)
-warning: [DownCastComposite] sync ? new _NoCallbackSyncStreamController() : new _NoCallbackAsyncStreamController() (_StreamController<dynamic>) will need runtime check to cast to type StreamController<T> (dart:async/stream_controller.dart, line 83, col 14)
+warning: [DownCastComposite] sync ? new _NoCallbackSyncStreamController<T>() : new _NoCallbackAsyncStreamController<T>() (_StreamController<dynamic>) will need runtime check to cast to type StreamController<T> (dart:async/stream_controller.dart, line 83, col 14)
 warning: [DownCastComposite] subscription (_ControllerSubscription<dynamic>) will need runtime check to cast to type StreamSubscription<T> (dart:async/stream_controller.dart, line 516, col 12)
 warning: [DownCastComposite] controller (_StreamController<dynamic>) will need runtime check to cast to type _EventSink<T> (dart:async/stream_controller.dart, line 798, col 15)
 warning: [DownCastComposite] _nullDataHandler ((dynamic) → void) will need runtime check to cast to type (T) → void (dart:async/stream_impl.dart, line 153, col 42)
@@ -229,10 +241,6 @@ warning: [DownCastComposite] test ((dynamic) → bool) will need runtime check t
 warning: [DownCastComposite] list (List<dynamic>) will need runtime check to cast to type Iterable<T> (dart:_internal/iterable.dart, line 997, col 40)
 warning: [DownCastComposite] list (List<dynamic>) will need runtime check to cast to type Iterable<T> (dart:_internal/iterable.dart, line 1033, col 35)
 warning: [DownCastComposite] l (List<dynamic>) will need runtime check to cast to type List<T> (dart:_internal/iterable.dart, line 1115, col 31)
-warning: [DownCastComposite] _convertToJS ((dynamic) → dynamic) will need runtime check to cast to type (E) → dynamic (dart:js, line 325, col 44)
-warning: [DownCastComposite] super[index] (dynamic) will need runtime check to cast to type E (dart:js, line 358, col 12)
-warning: [DownCastComposite] callMethod('splice', [index, 1])[0] (dynamic) will need runtime check to cast to type E (dart:js, line 404, col 12)
-warning: [DownCastComposite] callMethod('pop') (dynamic) will need runtime check to cast to type E (dart:js, line 409, col 12)
 warning: [DownCastComposite] x + other.x (num) will need runtime check to cast to type T (dart:math/point.dart, line 37, col 25)
 warning: [DownCastComposite] y + other.y (num) will need runtime check to cast to type T (dart:math/point.dart, line 37, col 38)
 warning: [DownCastComposite] x - other.x (num) will need runtime check to cast to type T (dart:math/point.dart, line 46, col 25)
@@ -268,3 +276,7 @@ warning: [DownCastComposite] min(a.y, b.y) (num) will need runtime check to cast
 warning: [DownCastComposite] max(a.y, b.y) - top (num) will need runtime check to cast to type T (dart:math/rectangle.dart, line 231, col 16)
 warning: [DownCastComposite] _clampToZero(width) (num) will need runtime check to cast to type T (dart:math/rectangle.dart, line 247, col 28)
 warning: [DownCastComposite] _clampToZero(height) (num) will need runtime check to cast to type T (dart:math/rectangle.dart, line 263, col 30)
+warning: [DownCastComposite] _convertToJS ((dynamic) → dynamic) will need runtime check to cast to type (E) → dynamic (dart:js, line 325, col 44)
+warning: [DownCastComposite] super[index] (dynamic) will need runtime check to cast to type E (dart:js, line 358, col 12)
+warning: [DownCastComposite] callMethod('splice', [index, 1])[0] (dynamic) will need runtime check to cast to type E (dart:js, line 404, col 12)
+warning: [DownCastComposite] callMethod('pop') (dynamic) will need runtime check to cast to type E (dart:js, line 409, col 12)