tool/sdk_expected_errors.txt - Issue 1486473002: Convert dart_utils.js to input_sdk/lib/_internal/utils.dart (#310)

Side by Side Diff: tool/sdk_expected_errors.txt

Issue 1486473002: Convert dart_utils.js to input_sdk/lib/_internal/utils.dart (#310) (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Safer args / simplification for JS intrinsics & other comments addressed Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tool/input_sdk/private/utils.dart ('k') | no next file » | no next file with comments »

OLD	NEW
1 severe: [AnalyzerMessage] The redirected constructor '(dynamic) → JSArray<dynami c>' has incompatible parameters with '(dynamic) → JSArray<E>' (dart:_interceptor s/js_array.dart, line 29, col 46)	1 severe: [AnalyzerMessage] The redirected constructor '(dynamic) → JSArray<dynami c>' has incompatible parameters with '(dynamic) → JSArray<E>' (dart:_interceptor s/js_array.dart, line 29, col 46)

2 severe: [AnalyzerMessage] Missing concrete implementation of 'num.==' (dart:_int erceptors/js_number.dart, line 12, col 7)	2 severe: [AnalyzerMessage] Missing concrete implementation of 'num.==' (dart:_int erceptors/js_number.dart, line 12, col 7)

3 severe: [AnalyzerMessage] Missing concrete implementation of 'String.==' (dart:_ interceptors/js_string.dart, line 14, col 7)	3 severe: [AnalyzerMessage] Missing concrete implementation of 'String.==' (dart:_ interceptors/js_string.dart, line 14, col 7)

	4 severe: [AnalyzerMessage] 'const' variables must be constant value (dart:_utils, line 13, col 24)
	Jennifer Messerly 2015/12/01 15:56:37 Declare these variables as "final"? If that gener Declare these variables as "final"? If that generates weird code, maybe have js_codegen special case the following pattern: final foo = JS(...); ochafik 2015/12/01 18:48:25 Good ideal, preparing a follow-up now as the speci Show quoted text On 2015/12/01 15:56:37, John Messerly wrote: > Declare these variables as "final"? > > If that generates weird code, maybe have js_codegen special case the following > pattern: > > final foo = JS(...); Good ideal, preparing a follow-up now as the special-casing impacts some other files (js_mirrors, isolate_helpers, js)
	5 severe: [AnalyzerMessage] 'const' variables must be constant value (dart:_utils, line 14, col 34)

	6 severe: [AnalyzerMessage] 'const' variables must be constant value (dart:_utils, line 15, col 29)

	7 severe: [AnalyzerMessage] 'const' variables must be constant value (dart:_utils, line 16, col 31)

	8 severe: [AnalyzerMessage] 'const' variables must be constant value (dart:_utils, line 18, col 24)

	9 severe: [AnalyzerMessage] 'const' variables must be constant value (dart:_utils, line 21, col 25)

4 severe: [AnalyzerMessage] The redirected constructor '((Stream<dynamic>, bool) → StreamSubscription<dynamic>) → _StreamSubscriptionTransformer<dynamic, dynamic> ' has incompatible parameters with '((Stream<S>, bool) → StreamSubscription<T>) → StreamTransformer<S, T>' (dart:async/stream.dart, line 1571, col 9)	10 severe: [AnalyzerMessage] The redirected constructor '((Stream<dynamic>, bool) → StreamSubscription<dynamic>) → _StreamSubscriptionTransformer<dynamic, dynamic> ' has incompatible parameters with '((Stream<S>, bool) → StreamSubscription<T>) → StreamTransformer<S, T>' (dart:async/stream.dart, line 1571, col 9)

5 severe: [AnalyzerMessage] The redirected constructor '({handleData: (dynamic, Ev entSink<dynamic>) → void, handleError: (Object, StackTrace, EventSink<dynamic>) → void, handleDone: (EventSink<dynamic>) → void}) → _StreamHandlerTransformer<dy namic, dynamic>' has incompatible parameters with '({handleData: (S, EventSink<T >) → void, handleError: (Object, StackTrace, EventSink<T>) → void, handleDone: ( EventSink<T>) → void}) → StreamTransformer<S, T>' (dart:async/stream.dart, line 1588, col 13)	11 severe: [AnalyzerMessage] The redirected constructor '({handleData: (dynamic, Ev entSink<dynamic>) → void, handleError: (Object, StackTrace, EventSink<dynamic>) → void, handleDone: (EventSink<dynamic>) → void}) → _StreamHandlerTransformer<dy namic, dynamic>' has incompatible parameters with '({handleData: (S, EventSink<T >) → void, handleError: (Object, StackTrace, EventSink<T>) → void, handleDone: ( EventSink<T>) → void}) → StreamTransformer<S, T>' (dart:async/stream.dart, line 1588, col 13)

6 severe: [AnalyzerMessage] The type '_NoCallbackSyncStreamController' is declared with 0 type parameters, but 1 type arguments were given (dart:async/stream_cont roller.dart, line 84, col 17)	12 severe: [AnalyzerMessage] The type '_NoCallbackSyncStreamController' is declared with 0 type parameters, but 1 type arguments were given (dart:async/stream_cont roller.dart, line 84, col 17)

7 severe: [AnalyzerMessage] The type '_NoCallbackAsyncStreamController' is declare d with 0 type parameters, but 1 type arguments were given (dart:async/stream_con troller.dart, line 85, col 17)	13 severe: [AnalyzerMessage] The type '_NoCallbackAsyncStreamController' is declare d with 0 type parameters, but 1 type arguments were given (dart:async/stream_con troller.dart, line 85, col 17)

8 severe: [AnalyzerMessage] The name 'T' is not a type and cannot be used as a par ameterized type (dart:async/stream_controller.dart, line 653, col 69)	14 severe: [AnalyzerMessage] The name 'T' is not a type and cannot be used as a par ameterized type (dart:async/stream_controller.dart, line 653, col 69)

9 severe: [AnalyzerMessage] The name 'T' is not a type and cannot be used as a par ameterized type (dart:async/stream_controller.dart, line 654, col 46)	15 severe: [AnalyzerMessage] The name 'T' is not a type and cannot be used as a par ameterized type (dart:async/stream_controller.dart, line 654, col 46)

10 severe: [AnalyzerMessage] The name 'T' is not a type and cannot be used as a par ameterized type (dart:async/stream_controller.dart, line 656, col 68)	16 severe: [AnalyzerMessage] The name 'T' is not a type and cannot be used as a par ameterized type (dart:async/stream_controller.dart, line 656, col 68)

11 severe: [AnalyzerMessage] The name 'T' is not a type and cannot be used as a par ameterized type (dart:async/stream_controller.dart, line 657, col 45)	17 severe: [AnalyzerMessage] The name 'T' is not a type and cannot be used as a par ameterized type (dart:async/stream_controller.dart, line 657, col 45)

12 severe: [AnalyzerMessage] The redirected constructor '((List<dynamic>) → void) → _SimpleCallbackSink<dynamic>' has incompatible parameters with '((List<T>) → vo id) → ChunkedConversionSink<T>' (dart:convert/chunked_conversion.dart, line 23, col 45)	18 severe: [AnalyzerMessage] The redirected constructor '((List<dynamic>) → void) → _SimpleCallbackSink<dynamic>' has incompatible parameters with '((List<T>) → vo id) → ChunkedConversionSink<T>' (dart:convert/chunked_conversion.dart, line 23, col 45)

13 severe: [AnalyzerMessage] The redirected constructor '(Iterable<E>) → LinkedHash Set<E>' has incompatible parameters with '(Iterable<dynamic>) → Set<E>' (dart:co re/set.dart, line 75, col 41)	19 severe: [AnalyzerMessage] The redirected constructor '(Iterable<E>) → LinkedHash Set<E>' has incompatible parameters with '(Iterable<dynamic>) → Set<E>' (dart:co re/set.dart, line 75, col 41)

(...skipping 253 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
267 warning: [DownCastComposite] min(a.y, b.y) (num) will need runtime check to cast to type T (dart:math/rectangle.dart, line 169, col 13)	273 warning: [DownCastComposite] min(a.y, b.y) (num) will need runtime check to cast to type T (dart:math/rectangle.dart, line 169, col 13)

268 warning: [DownCastComposite] max(a.y, b.y) - top (num) will need runtime check t o cast to type T (dart:math/rectangle.dart, line 170, col 16)	274 warning: [DownCastComposite] max(a.y, b.y) - top (num) will need runtime check t o cast to type T (dart:math/rectangle.dart, line 170, col 16)

269 warning: [DownCastComposite] (width < 0) ? _clampToZero(width) : width (num) wil l need runtime check to cast to type T (dart:math/rectangle.dart, line 212, col 23)	275 warning: [DownCastComposite] (width < 0) ? _clampToZero(width) : width (num) wil l need runtime check to cast to type T (dart:math/rectangle.dart, line 212, col 23)

270 warning: [DownCastComposite] (height < 0) ? _clampToZero(height) : height (num) will need runtime check to cast to type T (dart:math/rectangle.dart, line 213, c ol 24)	276 warning: [DownCastComposite] (height < 0) ? _clampToZero(height) : height (num) will need runtime check to cast to type T (dart:math/rectangle.dart, line 213, c ol 24)

271 warning: [DownCastComposite] min(a.x, b.x) (num) will need runtime check to cast to type T (dart:math/rectangle.dart, line 228, col 14)	277 warning: [DownCastComposite] min(a.x, b.x) (num) will need runtime check to cast to type T (dart:math/rectangle.dart, line 228, col 14)

272 warning: [DownCastComposite] max(a.x, b.x) - left (num) will need runtime check to cast to type T (dart:math/rectangle.dart, line 229, col 15)	278 warning: [DownCastComposite] max(a.x, b.x) - left (num) will need runtime check to cast to type T (dart:math/rectangle.dart, line 229, col 15)

273 warning: [DownCastComposite] min(a.y, b.y) (num) will need runtime check to cast to type T (dart:math/rectangle.dart, line 230, col 13)	279 warning: [DownCastComposite] min(a.y, b.y) (num) will need runtime check to cast to type T (dart:math/rectangle.dart, line 230, col 13)

274 warning: [DownCastComposite] max(a.y, b.y) - top (num) will need runtime check t o cast to type T (dart:math/rectangle.dart, line 231, col 16)	280 warning: [DownCastComposite] max(a.y, b.y) - top (num) will need runtime check t o cast to type T (dart:math/rectangle.dart, line 231, col 16)

275 warning: [DownCastComposite] _clampToZero(width) (num) will need runtime check t o cast to type T (dart:math/rectangle.dart, line 247, col 28)	281 warning: [DownCastComposite] _clampToZero(width) (num) will need runtime check t o cast to type T (dart:math/rectangle.dart, line 247, col 28)

276 warning: [DownCastComposite] _clampToZero(height) (num) will need runtime check to cast to type T (dart:math/rectangle.dart, line 263, col 30)	282 warning: [DownCastComposite] _clampToZero(height) (num) will need runtime check to cast to type T (dart:math/rectangle.dart, line 263, col 30)

OLD	NEW