Convert dart_utils.js to input_sdk/lib/_internal/utils.dart (#310)

lib/runtime/dart/_internal.js

 dart_library.library('dart/_internal', null, /* Imports */[
   "dart/_runtime",
   'dart/core',
   'dart/collection'
 ], /* Lazy imports */[
   'dart/math',
   'dart/_interceptors',
   'dart/_js_primitives'
 ], function(exports, dart, core, collection, math, _interceptors, _js_primitives) {
   'use strict';
@@ skipping 602 matching lines @@
   });
   let _ExpandFunction = _ExpandFunction$();
   let ExpandIterable$ = dart.generic(function(S, T) {
     class ExpandIterable extends collection.IterableBase$(T) {
       ExpandIterable(iterable, f) {
         this[_iterable] = iterable;
         this[_f] = f;
         super.IterableBase();
       }
       get iterator() {
-        return new (ExpandIterator$(S, T))(this[_iterable][dartx.iterator], dart.as(this[_f], __CastType0));
+        return new (ExpandIterator$(S, T))(this[_iterable][dartx.iterator], dart.as(this[_f], __CastType0$(S, T)));

[vsm, 2015/11/30 16:50:06]

Do you know what change triggered this?  The new version looks better, but we
probably ought to fix the Dart code to eliminate this cast.

[Jennifer Messerly, 2015/11/30 18:54:11]

Just a guess: I changed Analyzer to use FunctionElement instead of fake typedefs
for function typed parameters, and fixed its enclosingElement to correctly track
type parameters. It looks like the result is they're tracking generic
substitutions better. It wasn't my intent but it looks like maybe it fixed a
soundness issue.

       }
     }
     dart.setSignature(ExpandIterable, {
       constructors: () => ({ExpandIterable: [ExpandIterable$(S, T), [core.Iterable$(S), dart.functionType(core.Iterable$(T), [S])]]})
     });
     dart.defineExtensionMembers(ExpandIterable, ['iterator']);
     return ExpandIterable;
   });
   let ExpandIterable = ExpandIterable$();
   let _currentExpansion = dart.JsSymbol('_currentExpansion');
@@ skipping 676 matching lines @@
           buffer.write(list[dartx.get](0));
           for (let i = 1; dart.notNull(i) < dart.notNull(list[dartx.length]); i = dart.notNull(i) + 1) {
             buffer.write(separator);
             buffer.write(list[dartx.get](i));
           }
         }
         return dart.toString(buffer);
       }
       where(iterable, f) {
         dart.as(f, dart.functionType(core.bool, [dart.dynamic]));
-        return new (WhereIterable$(T))(dart.as(iterable, core.Iterable$(T)), dart.as(f, __CastType2));
+        return new (WhereIterable$(T))(dart.as(iterable, core.Iterable$(T)), dart.as(f, __CastType2$(T)));
       }
       static map(iterable, f) {
         dart.as(f, dart.functionType(dart.dynamic, [dart.dynamic]));
         return MappedIterable.new(iterable, f);
       }
       static mapList(list, f) {
         dart.as(f, dart.functionType(dart.dynamic, [dart.dynamic]));
         return new MappedListIterable(list, f);
       }
       static expand(iterable, f) {
@@ skipping 1117 matching lines @@
   exports.ReversedListIterable = ReversedListIterable;
   exports.UnmodifiableListError = UnmodifiableListError;
   exports.NonGrowableListError = NonGrowableListError;
   exports.makeListFixedLength = makeListFixedLength;
   exports.Lists = Lists;
   exports.printToConsole = printToConsole;
   exports.Sort = Sort;
   exports.Symbol = Symbol;
   exports.POWERS_OF_TEN = POWERS_OF_TEN;
 });