Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 148643002: Hide X11 dependencies when use_x11=0. (Closed)

Created:
6 years, 11 months ago by kalyank
Modified:
6 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Hide X11 dependencies when use_x11=0. When using a non X11 build with Ozone, we still have dependencies on X11. This patch tries to hide X11 and related dependencies when use_x11=0 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251981

Patch Set 1 #

Total comments: 8

Patch Set 2 : Review fixes. #

Patch Set 3 : Speculative fix for Android. #

Patch Set 4 : Rebased #

Patch Set 5 : Revert GTK related changes in forwarder. #

Patch Set 6 : Fix comments. #

Patch Set 7 : Rebase #

Patch Set 8 : Rebased #

Patch Set 9 : Rebase #

Patch Set 10 : Rebase: Needed changes in tools.gyp #

Patch Set 11 : Rebase: Needed changes in tools.gyp #

Patch Set 12 : Include compositor_model_bench for only x11 builds for now. #

Patch Set 13 : Include compositor_model_bench for only x11 builds for now. (Right Version) #

Total comments: 1

Patch Set 14 : Review Fix: remove blank lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+287 lines, -259 lines) Patch
M build/linux/system.gyp View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +249 lines, -244 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +6 lines, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +15 lines, -6 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +6 lines, -1 line 0 comments Download
M chrome/chrome_exe.gypi View 1 2 3 4 5 6 7 8 1 chunk +7 lines, -2 lines 0 comments Download
gpu/tools/tools.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M media/cast/cast.gyp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
tools/android/forwarder2/forwarder.gyp View 1 2 3 4 5 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 34 (0 generated)
kalyank
6 years, 11 months ago (2014-01-27 21:47:01 UTC) #1
rjkroege
lgtm But please carefully evaluate the try job results.
6 years, 11 months ago (2014-01-27 22:34:24 UTC) #2
kalyank
Adding sky@ for chrome/
6 years, 11 months ago (2014-01-27 23:52:06 UTC) #3
sky
LGTM https://codereview.chromium.org/148643002/diff/1/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): https://codereview.chromium.org/148643002/diff/1/chrome/chrome_browser.gypi#newcode3461 chrome/chrome_browser.gypi:3461: '../build/linux/system.gyp:x11', nit: indent this. https://codereview.chromium.org/148643002/diff/1/chrome/chrome_browser_extensions.gypi File chrome/chrome_browser_extensions.gypi (right): ...
6 years, 11 months ago (2014-01-28 00:43:07 UTC) #4
kalyank
https://codereview.chromium.org/148643002/diff/1/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): https://codereview.chromium.org/148643002/diff/1/chrome/chrome_browser.gypi#newcode3461 chrome/chrome_browser.gypi:3461: '../build/linux/system.gyp:x11', On 2014/01/28 00:43:07, sky wrote: > nit: indent ...
6 years, 11 months ago (2014-01-28 01:18:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalyan.kondapally@intel.com/148643002/20001
6 years, 11 months ago (2014-01-28 01:26:00 UTC) #6
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=109960
6 years, 11 months ago (2014-01-28 02:01:05 UTC) #7
kalyank
On 2014/01/28 02:01:05, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 10 months ago (2014-01-28 17:07:07 UTC) #8
kalyank
On 2014/01/28 17:07:07, kalyank wrote: > On 2014/01/28 02:01:05, I haz the power (commit-bot) wrote: ...
6 years, 10 months ago (2014-01-29 23:53:26 UTC) #9
Philippe
Thanks for fixing this! LGTM
6 years, 10 months ago (2014-01-30 08:42:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalyan.kondapally@intel.com/148643002/60001
6 years, 10 months ago (2014-01-30 13:12:30 UTC) #11
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=110909
6 years, 10 months ago (2014-01-30 13:55:18 UTC) #12
kalyank
On 2014/01/30 08:42:44, Philippe wrote: > Thanks for fixing this! LGTM @Philippe can you please ...
6 years, 10 months ago (2014-01-31 03:25:54 UTC) #13
kalyank
On 2014/01/31 03:25:54, kalyank wrote: > On 2014/01/30 08:42:44, Philippe wrote: > > Thanks for ...
6 years, 10 months ago (2014-02-03 17:20:54 UTC) #14
Philippe
Sorry for the delay, still lgtm if the bots are happy :)
6 years, 10 months ago (2014-02-04 09:46:48 UTC) #15
kalyank
The CQ bit was checked by kalyan.kondapally@intel.com
6 years, 10 months ago (2014-02-04 10:21:53 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalyan.kondapally@intel.com/148643002/140001
6 years, 10 months ago (2014-02-04 10:22:33 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 11:11:59 UTC) #18
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=223041
6 years, 10 months ago (2014-02-04 11:11:59 UTC) #19
kalyank
The CQ bit was checked by kalyan.kondapally@intel.com
6 years, 10 months ago (2014-02-04 16:15:07 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalyan.kondapally@intel.com/148643002/140001
6 years, 10 months ago (2014-02-04 16:15:52 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 17:40:16 UTC) #22
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120934
6 years, 10 months ago (2014-02-04 17:40:17 UTC) #23
kalyank
Adding hubbe@ for media/cast
6 years, 10 months ago (2014-02-06 01:48:14 UTC) #24
kalyank
On 2014/02/06 01:48:14, kalyank wrote: > Adding hubbe@ for media/cast @hubbe ping
6 years, 10 months ago (2014-02-07 21:21:20 UTC) #25
kalyank
On 2014/02/07 21:21:20, kalyank wrote: > On 2014/02/06 01:48:14, kalyank wrote: > > Adding hubbe@ ...
6 years, 10 months ago (2014-02-08 10:52:56 UTC) #26
mikhal1
lgtm
6 years, 10 months ago (2014-02-12 18:11:28 UTC) #27
kalyank
@piman for gpu/tools/tools.gyp
6 years, 10 months ago (2014-02-17 22:56:10 UTC) #28
piman
lgtm https://codereview.chromium.org/148643002/diff/1070001/gpu/tools/tools.gyp File gpu/tools/tools.gyp (right): https://codereview.chromium.org/148643002/diff/1070001/gpu/tools/tools.gyp#newcode17 gpu/tools/tools.gyp:17: nit: avoid blank lines in gyp files.
6 years, 10 months ago (2014-02-18 20:23:30 UTC) #29
kalyank
The CQ bit was checked by kalyan.kondapally@intel.com
6 years, 10 months ago (2014-02-19 02:08:09 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalyan.kondapally@intel.com/148643002/1190001
6 years, 10 months ago (2014-02-19 02:08:46 UTC) #31
commit-bot: I haz the power
Change committed as 251981
6 years, 10 months ago (2014-02-19 07:53:45 UTC) #32
vivekg
On 2014/02/19 07:53:45, I haz the power (commit-bot) wrote: > Change committed as 251981 This ...
6 years, 10 months ago (2014-02-19 17:14:51 UTC) #33
kalyank
6 years, 10 months ago (2014-02-19 21:04:34 UTC) #34
Message was sent while issue was closed. 
On 2014/02/19 17:14:51, vivekg_ wrote:
> On 2014/02/19 07:53:45, I haz the power (commit-bot) wrote:
> > Change committed as 251981
> 
> This has resulted in build break on my system while building for android. The
> error log [1]
> 
> I am using Linux Mint 15 Olivia 64-bit system. It worked once I reverted this
> patch locally. 
> 
> [1] http://pastebin.com/eLqcsvcd

Sorry, about this. Not sure why Android bots didn't show up this error. Ideally,
we don't have to link against message_pump_gtk on Android. Let's discuss this in
IIRC.

Powered by Google App Engine
This is Rietveld 408576698