Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1486413006: Reland of [heap] Remove eager shortcut in JSFunction visitor. (Closed)

Created:
5 years ago by Hannes Payer (out of office)
Modified:
5 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [heap] Remove eager shortcut in JSFunction visitor. (patchset #1 id:1 of https://codereview.chromium.org/1488063002/ ) Reason for revert: Suspect for crashing found, relanding for canary coverage. Original issue's description: > Revert of [heap] Remove eager shortcut in JSFunction visitor. (patchset #1 id:1 of https://codereview.chromium.org/1476223002/ ) > > Reason for revert: > Still investigating bad canary. > > Original issue's description: > > [heap] Remove eager shortcut in JSFunction visitor. > > > > This removes an optimization in the static JSFunction visitor that > > eagerly marked through to the SharedFunctionInfo for code flushing > > candidates. This causes all processing in VisitJSFunction to be > > side-stepped and hence might cause leaks. > > > > R=hpayer@chromium.org > > > > Committed: https://crrev.com/a29f0576c32e8fda90bf7ab19c6d170568150a7f > > Cr-Commit-Position: refs/heads/master@{#32332} > > TBR=mstarzinger@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/672b49119b857c4f96234b03e48b4b60de256969 > Cr-Commit-Position: refs/heads/master@{#32463} TBR=mstarzinger@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/2ee18a5d4057543d6f8140b0439b185444292af1 Cr-Commit-Position: refs/heads/master@{#32554}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M src/heap/objects-visiting-inl.h View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Hannes Payer (out of office)
Created Reland of [heap] Remove eager shortcut in JSFunction visitor.
5 years ago (2015-12-03 12:22:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486413006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486413006/1
5 years ago (2015-12-03 12:22:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 12:22:49 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-03 12:23:16 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ee18a5d4057543d6f8140b0439b185444292af1
Cr-Commit-Position: refs/heads/master@{#32554}

Powered by Google App Engine
This is Rietveld 408576698