Mojo-ifying chrome://version.

chrome/browser/extensions/active_tab_unittest.cc

Index: chrome/browser/extensions/active_tab_unittest.cc
diff --git a/chrome/browser/extensions/active_tab_unittest.cc b/chrome/browser/extensions/active_tab_unittest.cc
index be5668c04ca734c66eb5d8ad796f671aed8e0441..1a83bca3a7da778336a57a528e9de4cfc96dcaf1 100644
--- a/chrome/browser/extensions/active_tab_unittest.cc
+++ b/chrome/browser/extensions/active_tab_unittest.cc
@@ -361,7 +361,7 @@ TEST_F(ActiveTabTest, NavigateInPage) {
 }
 
 TEST_F(ActiveTabTest, ChromeUrlGrants) {
-  GURL internal("chrome://version");
+  GURL internal("chrome://about");

[dpapad, 2015/12/07 22:42:18]

@rdevlin.cronin:Is this fix OK for this test?
Context: I am converting chrome://version to use Mojo in this CL, and
instantiating a MojoWebUIController fails in the context of a unit test (error
pasted below).
#0 0x7f1ab8bd90bb base::debug::(anonymous namespace)::StackDumpSignalHandler()
#1 0x7f1ab29a7340 <unknown>
#2 0x000002a6a5d3 content::ServiceRegistry::AddService<>()
#3 0x000002a6a59a MojoWebUIController<>::RenderViewCreated()
#4 0x7f1ab735dc24 content::RenderFrameHostManager::UpdateStateForNavigate()
#5 0x7f1ab735d71e content::RenderFrameHostManager::Navigate()
#6 0x7f1ab734ee50 content::NavigatorImpl::NavigateToEntry()

If the exact chrome URL is not relevant here, this change should be OK.

@sky, rdevlin.cronin: Eventually this case will come up again (as more WebUI is
converted to use Mojo), so a better solution would be needed. I see an example
usage of TestChromeWebUIControllerFactory at
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/base/w...,
is this the recommended way?

[Devlin, 2015/12/07 22:47:52]

As long as the test passes, this url should be fine.

I'm not particularly familiar with mojo, so I'll let Sky answer the second part.

[sky, 2015/12/08 00:19:55]

I believe using a WebUIBrowserTest is likely much heavier than a unit test, and
susceptible to more flake. I'm not sure what the right answer is. It may be to
make ChromeRenderViewHostTestHarness work with mojo, but I'm not positive. I
recommend filing a bug on this and talking with Ken Rockot about it.

   NavigateAndCommit(internal);
   active_tab_permission_granter()->GrantIfRequested(
       extension_with_tab_capture.get());