Mojo-ifying chrome://version.

chrome/browser/ui/webui/version_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_VERSION_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_VERSION_HANDLER_H_
 
 #include <vector>
 
 #include "base/memory/weak_ptr.h"
 #include "base/values.h"
-#include "content/public/browser/web_ui_message_handler.h"
+#include "chrome/browser/ui/webui/mojo_web_ui_handler.h"
+#include "chrome/browser/ui/webui/version.mojom.h"
+#include "content/public/browser/web_ui.h"
 #include "content/public/common/webplugininfo.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
 
 // Handler class for Version page operations.
-class VersionHandler : public content::WebUIMessageHandler {
+class VersionHandler : public MojoWebUIHandler, public VersionHandlerMojo {
  public:
-  VersionHandler();
+  VersionHandler(content::WebUI* web_ui,
+                 mojo::InterfaceRequest<VersionHandlerMojo> request);
   ~VersionHandler() override;
 
-  // content::WebUIMessageHandler implementation.
-  void RegisterMessages() override;
-
-  // Callback for the "requestVersionInfo" message. This asynchronously requests
-  // the flash version and eventually returns it to the front end along with the
-  // list of variations using OnGotPlugins.
-  virtual void HandleRequestVersionInfo(const base::ListValue* args);
+  // VersionHandlerMojo overrides:
+  void GetFilePaths(const GetFilePathsCallback& callback) override;
+  void GetFlashVersion(const GetFlashVersionCallback& callback) override;
+  void GetVariations(const GetVariationsCallback& callback) override;
+  void GetOsVersion(const GetOsVersionCallback& callback) override;
 
  private:
   // Callback which handles returning the executable and profile paths to the
   // front end.
   void OnGotFilePaths(base::string16* executable_path_data,
-                      base::string16* profile_path_data);
+                      base::string16* profile_path_data,
+                      const GetFilePathsCallback& callback);
 
+#if defined(ENABLE_PLUGINS)
   // Callback for GetPlugins which responds to the page with the Flash version.
-  // This also initiates the OS Version load on ChromeOS.
-  void OnGotPlugins(const std::vector<content::WebPluginInfo>& plugins);
+  void OnGotPlugins(const GetFlashVersionCallback& callback,
+                    const std::vector<content::WebPluginInfo>& plugins);
+#endif  // defined(ENABLE_PLUGINS)
+#if defined(OS_CHROMEOS)
+  void OnGotOsVersion(const GetOsVersionCallback& callback,
+                      const std::string& version);
+#endif  // defined(OS_CHROMEOS)
+
+  content::WebUI* web_ui_;
+  mojo::StrongBinding<VersionHandlerMojo> binding_;

[sky, 2015/12/10 16:20:34]

Normally MojoWebUIHandler is owned by content. StrongBinding means if the pipe
goes away the implemention of VersionHandlerMojo (in this case it is 'this')
would be deleted. So, use a Binding here.

[dpapad, 2015/12/10 18:40:19]

Done.

 
   // Factory for the creating refs in callbacks.
   base::WeakPtrFactory<VersionHandler> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(VersionHandler);
 };
 
 #endif  // CHROME_BROWSER_UI_WEBUI_VERSION_HANDLER_H_