components/resources/version_ui_resources.grdp - Issue 1486403002: Mojo-ifying chrome://version.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/resources/version_ui_resources.grdp

Issue 1486403002: Mojo-ifying chrome://version. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing DOMContentLoaded TODO. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <grit-part>	2 <grit-part>

3 <include name="IDR_VERSION_UI_CSS" file="../version_ui/resources/about_version .css" type="BINDATA" />	3 <include name="IDR_VERSION_UI_CSS" file="../version_ui/resources/about_version .css" type="BINDATA" />

4 <include name="IDR_VERSION_UI_HTML" file="../version_ui/resources/about_versio n.html" flattenhtml="true" allowexternalscript="true" type="BINDATA" />	4 <include name="IDR_VERSION_UI_HTML" file="../version_ui/resources/about_versio n.html" flattenhtml="true" allowexternalscript="true" type="BINDATA" />
	Dan Beam 2015/12/09 21:45:07 should this if <if expr="is_ios">? should this if <if expr="is_ios">?
	5 <include name="IDR_VERSION_UI_IOS_JS" file="../version_ui/resources/about_vers ion_ios.js" type="BINDATA" />

5 <include name="IDR_VERSION_UI_JS" file="../version_ui/resources/about_version. js" type="BINDATA" />	6 <include name="IDR_VERSION_UI_JS" file="../version_ui/resources/about_version. js" type="BINDATA" />

6 </grit-part>	7 </grit-part>

OLD	NEW