components/version_ui/version_handler_helper.h - Issue 1486403002: Mojo-ifying chrome://version.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/version_ui/version_handler_helper.h

Issue 1486403002: Mojo-ifying chrome://version. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/version_ui/resources/about_version.js ('K') | « components/version_ui/resources/about_version_ios.js ('k') | components/version_ui/version_handler_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_VERSION_UI_VERSION_HANDLER_HELPER_H_	5 #ifndef COMPONENTS_VERSION_UI_VERSION_HANDLER_HELPER_H_

6 #define COMPONENTS_VERSION_UI_VERSION_HANDLER_HELPER_H_	6 #define COMPONENTS_VERSION_UI_VERSION_HANDLER_HELPER_H_

7	7

	8 #include <vector>

	9

8 #include "base/memory/scoped_ptr.h"	10 #include "base/memory/scoped_ptr.h"

9	11

10 namespace base {	12 namespace base {

11 class Value;	13 class Value;

12 }	14 }

13	15

14 namespace version_ui {	16 namespace version_ui {

15	17

	18 scoped_ptr<std::vector<std::string>> GetVariations();
	Evan Stade 2015/12/04 19:50:28 I think C++11 move semantics means it's ok to just I think C++11 move semantics means it's ok to just return std::vector dpapad 2015/12/04 22:01:51 Done. Thanks, I really like this feature of C++ 11 Show quoted text On 2015/12/04 at 19:50:28, Evan Stade wrote: > I think C++11 move semantics means it's ok to just return std::vector Done. Thanks, I really like this feature of C++ 11.
	19

	20 #if defined(OS_IOS)

16 // Returns the list of variations to be displayed on the chrome:://version page.	21 // Returns the list of variations to be displayed on the chrome:://version page.

17 scoped_ptr<base::Value> GetVariationsList();	22 scoped_ptr<base::Value> GetVariationsList();

	23 #endif

18	24

19 } // namespace version_ui	25 } // namespace version_ui

20	26

21 #endif // COMPONENTS_VERSION_UI_VERSION_HANDLER_HELPER_H_	27 #endif // COMPONENTS_VERSION_UI_VERSION_HANDLER_HELPER_H_

OLD	NEW