Keep track of when a socket has been destroyed

runtime/bin/eventhandler_win.cc

-// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
+// Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_WINDOWS)
 
 #include "bin/eventhandler.h"
 
 #include <process.h>  // NOLINT
 #include <winsock2.h>  // NOLINT
@@ skipping 305 matching lines @@
 void FileHandle::EnsureInitialized(EventHandlerImplementation* event_handler) {
   ScopedLock lock(this);
   event_handler_ = event_handler;
   if (SupportsOverlappedIO() && completion_port_ == INVALID_HANDLE_VALUE) {
     CreateCompletionPort(event_handler_->completion_port());
   }
 }
 
 
 bool FileHandle::IsClosed() {
-  return false;
+  return IsClosing();
 }
 
 
 void FileHandle::DoClose() {
   if (GetStdHandle(STD_OUTPUT_HANDLE) == handle_) {
     int fd = _open("NUL", _O_WRONLY);
     ASSERT(fd >= 0);
     _dup2(fd, _fileno(stdout));
     close(fd);
   } else {
@@ skipping 228 matching lines @@
   if (how == SD_RECEIVE) MarkClosedRead();
   if (how == SD_SEND) MarkClosedWrite();
   if (how == SD_BOTH) {
     MarkClosedRead();
     MarkClosedWrite();
   }
 }
 
 
 void ClientSocket::DoClose() {
-  // Always do a suhtdown before initiating a disconnect.
+  // Always do a shutdown before initiating a disconnect.
   shutdown(socket(), SD_BOTH);
   IssueDisconnect();
 }
 
 
 bool ClientSocket::IssueRead() {
   ScopedLock lock(this);
   ASSERT(completion_port_ != INVALID_HANDLE_VALUE);
   ASSERT(pending_read_ == NULL);
 
@@ skipping 36 matching lines @@
     return true;
   }
   IOBuffer::DisposeBuffer(pending_write_);
   pending_write_ = NULL;
   HandleIssueError();
   return false;
 }
 
 
 void ClientSocket::IssueDisconnect() {
+  Dart_Port p = port();
   IOBuffer* buffer = IOBuffer::AllocateDisconnectBuffer();
   BOOL ok = DisconnectEx_(
     socket(), buffer->GetCleanOverlapped(), TF_REUSE_SOCKET, 0);
   if (!ok && WSAGetLastError() != WSA_IO_PENDING) {
     DisconnectComplete(buffer);
   }
+  if (p != ILLEGAL_PORT) DartUtils::PostInt32(p, 1 << kDestroyedEvent);

[kustermann, 2013/07/18 11:34:46]

If you closed a socket with 'DisconnectEx_' then you should send back the
destroy event. Why do you have this condition here?

[Anders Johnsen, 2013/07/19 10:49:07]

In Socket::Connect we can end up creating a socket and then deleting it, before
we get it back in to Dart, thus not having a Dart port associated.

 }
 
 
 void ClientSocket::DisconnectComplete(IOBuffer* buffer) {
   IOBuffer::DisposeBuffer(buffer);
   closesocket(socket());
   if (data_ready_ != NULL) {
     IOBuffer::DisposeBuffer(data_ready_);
   }
   // When disconnect is complete get rid of the object.
@@ skipping 100 matching lines @@
             client_socket->Shutdown(SD_RECEIVE);
           }
 
           if ((msg->data & (1 << kShutdownWriteCommand)) != 0) {
             client_socket->Shutdown(SD_SEND);
           }
         }
       }
 
       if ((msg->data & (1 << kCloseCommand)) != 0) {
+        handle->SetPortAndMask(msg->dart_port, msg->data);
         handle->Close();

[kustermann, 2013/07/18 11:34:46]

I thought 'handle->Close()' will result in 'IssueDisconnect()'.

[Anders Johnsen, 2013/07/19 10:49:07]

It will, but this is for more kinds than just ClientSocket.

         if (handle->IsClosed()) {
           delete_handle = true;
         }
       }
     }
     if (delete_handle) {
+      Dart_Port port = handle->port();
       delete handle;
+      DartUtils::PostInt32(port, 1 << kDestroyedEvent);

[kustermann, 2013/07/18 11:34:46]

Why do you do it here again?

[Anders Johnsen, 2013/07/19 10:49:07]

ClientSocket will never be delete any other place than in DisconnectComplete.

     }
   }
 }
 
 
 void EventHandlerImplementation::HandleAccept(ListenSocket* listen_socket,
                                               IOBuffer* buffer) {
   listen_socket->AcceptComplete(buffer, completion_port_);
 
   if (!listen_socket->IsClosing()) {
     int event_mask = 1 << kInEvent;
     if ((listen_socket->mask() & event_mask) != 0) {
       DartUtils::PostInt32(listen_socket->port(), event_mask);
     }
   }
 
   if (listen_socket->IsClosed()) {
+    Dart_Port port = listen_socket->port();
     delete listen_socket;
+    DartUtils::PostInt32(port, 1 << kDestroyedEvent);

[kustermann, 2013/07/18 11:34:46]

I don't understand why these PostInt32(kDestroyEvent) are all over the place
here.

[Anders Johnsen, 2013/07/19 10:49:07]

Every time we delete a socket, we send a destroy event (with ClientSocket being
an 'exception' to some degree.

   }
 }
 
 
 void EventHandlerImplementation::HandleClosed(Handle* handle) {
   if (!handle->IsClosing()) {
     int event_mask = 1 << kCloseEvent;
     DartUtils::PostInt32(handle->port(), event_mask);
   }
 }
@@ skipping 24 matching lines @@
   } else {
     handle->MarkClosedRead();
     if (bytes == 0) {
       HandleClosed(handle);
     } else {
       HandleError(handle);
     }
   }
 
   if (handle->IsClosed()) {
+    Dart_Port port = handle->port();
     delete handle;
+    DartUtils::PostInt32(port, 1 << kDestroyedEvent);
   }
 }
 
 
 void EventHandlerImplementation::HandleWrite(Handle* handle,
                                              int bytes,
                                              IOBuffer* buffer) {
   handle->WriteComplete(buffer);
 
   if (bytes > 0) {
     if (!handle->IsError() && !handle->IsClosing()) {
       int event_mask = 1 << kOutEvent;
       if ((handle->mask() & event_mask) != 0) {
         DartUtils::PostInt32(handle->port(), event_mask);
       }
     }
   } else if (bytes == 0) {
     HandleClosed(handle);
   } else {
     HandleError(handle);
   }
 
   if (handle->IsClosed()) {
+    Dart_Port port = handle->port();
     delete handle;
+    DartUtils::PostInt32(port, 1 << kDestroyedEvent);
   }
 }
 
 
 void EventHandlerImplementation::HandleDisconnect(
     ClientSocket* client_socket,
     int bytes,
     IOBuffer* buffer) {
   client_socket->DisconnectComplete(buffer);
 }
@@ skipping 148 matching lines @@
 
 
 void EventHandlerImplementation::Shutdown() {
   SendData(kShutdownId, 0, 0);
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_WINDOWS)