Issue 14864002: Fix GL extension printing on core profiles.

Issue 14864002: Fix GL extension printing on core profiles. (Closed)

Created:
7 years, 7 months ago by bsalomon

Modified:
7 years, 7 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix GL extension printing on core profiles. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=8970

Patch Set 3 : #

Total comments: 4

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -5 lines)			Patch
M	include/gpu/gl/GrGLExtensions.h	View		1 chunk	+2 lines, -0 lines	2 comments	Download
M	src/gpu/gl/GrGLContext.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGLExtensions.cpp	View	1 2	1 chunk	+11 lines, -0 lines	2 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + 2 suggestions https://codereview.chromium.org/14864002/diff/12001/include/gpu/gl/GrGLExtensions.h File include/gpu/gl/GrGLExtensions.h (right): https://codereview.chromium.org/14864002/diff/12001/include/gpu/gl/GrGLExtensions.h#newcode42 include/gpu/gl/GrGLExtensions.h:42: const char * -> char? ...

7 years, 7 months ago (2013-05-02 19:39:14 UTC) #2

bsalomon

https://codereview.chromium.org/14864002/diff/12001/include/gpu/gl/GrGLExtensions.h File include/gpu/gl/GrGLExtensions.h (right): https://codereview.chromium.org/14864002/diff/12001/include/gpu/gl/GrGLExtensions.h#newcode42 include/gpu/gl/GrGLExtensions.h:42: On 2013/05/02 19:39:14, robertphillips wrote: > const char * ...

7 years, 7 months ago (2013-05-02 19:41:59 UTC) #3

bsalomon

7 years, 7 months ago (2013-05-02 19:42:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r8970 (presubmit successful).

Expand Messages | Collapse Messages