Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 1486383003: [turbofan] Optimize %_IsJSReceiver based on input type. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Optimize %_IsJSReceiver based on input type. We can constant fold %_IsJSReceiver(x) based on whether x is always a receiver or can never be a receiver. This is important as %_IsJSReceiver is inserted by the JSInliner. R=jarin@chromium.org BUG=v8:4544 LOG=n Committed: https://crrev.com/ddb9f461f1aea1df67bb87266b39653ed1b8a9eb Cr-Commit-Position: refs/heads/master@{#32519}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -39 lines) Patch
M src/compiler/js-intrinsic-lowering.cc View 1 chunk +36 lines, -33 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 5 chunks +33 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years ago (2015-12-02 14:06:07 UTC) #1
Benedikt Meurer
Hey Jaro, Here's a small one that gives us a nice 5% boost on Octane ...
5 years ago (2015-12-02 14:07:40 UTC) #2
Jarin
Nice! lgtm.
5 years ago (2015-12-02 14:14:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486383003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486383003/1
5 years ago (2015-12-02 14:18:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 14:35:47 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-02 14:35:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ddb9f461f1aea1df67bb87266b39653ed1b8a9eb
Cr-Commit-Position: refs/heads/master@{#32519}

Powered by Google App Engine
This is Rietveld 408576698