Issue 1486383002: Merge to XFA: Add basic checking for RebuildCrossRef

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1486383002: Merge to XFA: Add basic checking for RebuildCrossRef (Closed)

Created:
5 years ago by Wei Li

Modified:
5 years ago

Reviewers:
jun_fang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Add basic checking for RebuildCrossRef RebuildCrossRef function returns false when we can not find file trailer or any indirect object. This serves as a basic file format checking. BUG=pdfium:215 TBR=jun_fang@foxitsoftware.com Review URL: https://codereview.chromium.org/1476163002 . (cherry picked from commit f14da1d58e8e12633c7a47e6efd5ffe43bb37b4b) Committed: https://pdfium.googlesource.com/pdfium/+/7d1578a9ac083bf186dc3297885bfc56fdb78540

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -12 lines)			Patch
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp	View	3 chunks	+6 lines, -12 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp	View	2 chunks	+11 lines, -0 lines	0 comments	Download
A	testing/resources/parser_rebuildxref_error_notrailer.pdf	View	1 chunk	+51 lines, -0 lines	0 comments	Download

Total messages: 3 (1 generated)

Wei Li

5 years ago (2015-12-02 01:45:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7d1578a9ac083bf186dc3297885bfc56fdb78540 (presubmit successful).