Kill ScopedPtrMap and friends

Kill ScopedPtrMap and friends

C++ 11 enables containers that contain move-only type, scoped_ptr.
So, Remove ScopedPtrMap and use std::map<key, scoped_ptr<Foo>> instead.

BUG=554291
Committed: https://crrev.com/93f52367cfe2ce652cebdbd213bc3f976d3c6c7b
Cr-Commit-Position: refs/heads/master@{#362615}

[limasdf, 2015-12-02 00:00:54]

Description was changed from

==========
Kill ScopedPtrMap and friends

Kill ScopedPtrMap and friends

C++ 11 enables containers that contain move-only type, scoped_ptr.
So, Remove ScopedPtrMap and use std::map<key, scoped_ptr<Foo>> instead.

BUG=554291
==========

to

==========
Kill ScopedPtrMap and friends

C++ 11 enables containers that contain move-only type, scoped_ptr.
So, Remove ScopedPtrMap and use std::map<key, scoped_ptr<Foo>> instead.

BUG=554291
==========

[limasdf, 2015-12-02 00:00:54]

limasdf@gmail.com changed reviewers:
+ rockot@chromium.org, thakis@chromium.org

[limasdf, 2015-12-02 00:02:29]

limasdf@gmail.com changed reviewers:
+ reillyg@chromium.org
- rockot@chromium.org

[limasdf, 2015-12-02 00:04:33]

limasdf@gmail.com changed reviewers:
+ rockot@chromium.org
- reillyg@chromium.org

[limasdf, 2015-12-02 00:04:33]

Nico for /base, /ui
Reilly for /extensions, /device

Adding Matt FYI.

[limasdf, 2015-12-02 00:04:58]

limasdf@gmail.com changed reviewers:
+ reillyg@chromium.org

[Matt Giuca, 2015-12-02 00:07:37]

On 2015/12/02 00:04:33, limasdf wrote:
> Nico for /base, /ui
> Reilly for /extensions, /device
> 
> Adding Matt FYI.

Thanks for doing all of this work! (I thought there were some usages that we
couldn't port over yet, maybe I'm mistaken.)

I would split this into two CLs: one to remove the final usages and another to
remove ScopedPtrMap itself. But I don't feel very strongly about this. LGTM.

[Matt Giuca, 2015-12-02 00:07:57]

mgiuca@chromium.org changed reviewers:
+ mgiuca@chromium.org

[Matt Giuca, 2015-12-02 00:07:57]

+danakj FYI

[danakj, 2015-12-02 00:09:20]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2015-12-02 00:09:21]

base LGTM

[vmpstr, 2015-12-02 00:09:37]

https://codereview.chromium.org/1486333002/diff/1/device/bluetooth/dbus/fake_...
File device/bluetooth/dbus/fake_bluetooth_device_client.h (right):

https://codereview.chromium.org/1486333002/diff/1/device/bluetooth/dbus/fake_...
device/bluetooth/dbus/fake_bluetooth_device_client.h:307: PairingOptionsMap
pairing_options_map_;
This one might need the DISALLOW_COPY_AND_ASSIGN (if windows bots complain)

[Reilly Grant (use Gerrit), 2015-12-02 00:13:27]

//device lgtm
//extensions lgtm

[limasdf, 2015-12-02 00:17:58]

It would be good to run 'CQ dry-run'. Would somebody run it?

(I compiled from my local PC, though)

[danakj, 2015-12-02 00:19:46]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-02 00:24:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1486333002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1486333002/1

[commit-bot: I haz the power, 2015-12-02 01:32:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-02 01:32:56]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[danakj, 2015-12-02 01:55:50]

On 2015/12/02 00:17:58, limasdf wrote:
> It would be good to run 'CQ dry-run'. Would somebody run it?
> 
> (I compiled from my local PC, though)

looks green

[limasdf, 2015-12-02 01:56:35]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2015-12-02 01:59:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1486333002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1486333002/1

[Nico, 2015-12-02 02:09:10]

very cool, thank you for all the work you put into this :-)

https://codereview.chromium.org/1486333002/diff/1/device/bluetooth/dbus/fake_...
File device/bluetooth/dbus/fake_bluetooth_device_client.h (right):

https://codereview.chromium.org/1486333002/diff/1/device/bluetooth/dbus/fake_...
device/bluetooth/dbus/fake_bluetooth_device_client.h:307: PairingOptionsMap
pairing_options_map_;
On 2015/12/02 00:09:36, vmpstr wrote:
> This one might need the DISALLOW_COPY_AND_ASSIGN (if windows bots complain)

dbus/ is probably not built on windows

[limasdf, 2015-12-02 02:14:50]

I learned a lot while fixing this issue.
Thank you for helping me everybody!!

btw, Nico, I need LGTM from you for /ui.

[Nico, 2015-12-02 02:46:46]

ui lgtm

[commit-bot: I haz the power, 2015-12-02 02:52:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-02 02:52:50]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[limasdf, 2015-12-02 03:18:16]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2015-12-02 03:18:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1486333002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1486333002/1

[commit-bot: I haz the power, 2015-12-02 03:23:30]

Description was changed from

==========
Kill ScopedPtrMap and friends

C++ 11 enables containers that contain move-only type, scoped_ptr.
So, Remove ScopedPtrMap and use std::map<key, scoped_ptr<Foo>> instead.

BUG=554291
==========

to

==========
Kill ScopedPtrMap and friends

C++ 11 enables containers that contain move-only type, scoped_ptr.
So, Remove ScopedPtrMap and use std::map<key, scoped_ptr<Foo>> instead.

BUG=554291
==========

[commit-bot: I haz the power, 2015-12-02 03:23:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-02 03:24:21]

Description was changed from

==========
Kill ScopedPtrMap and friends

C++ 11 enables containers that contain move-only type, scoped_ptr.
So, Remove ScopedPtrMap and use std::map<key, scoped_ptr<Foo>> instead.

BUG=554291
==========

to

==========
Kill ScopedPtrMap and friends

C++ 11 enables containers that contain move-only type, scoped_ptr.
So, Remove ScopedPtrMap and use std::map<key, scoped_ptr<Foo>> instead.

BUG=554291

Committed: https://crrev.com/93f52367cfe2ce652cebdbd213bc3f976d3c6c7b
Cr-Commit-Position: refs/heads/master@{#362615}
==========

[commit-bot: I haz the power, 2015-12-02 03:24:22]

Patchset 1 (id:??) landed as
https://crrev.com/93f52367cfe2ce652cebdbd213bc3f976d3c6c7b
Cr-Commit-Position: refs/heads/master@{#362615}