Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1486323003: X87: [turbofan] Added the optional Float64RoundTiesEven operator to turbofan. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Added the optional Float64RoundTiesEven operator to turbofan. port dffecf31fc069c9522bcb09df7c063a9710f6470 (r32005) original commit message: The TiesEven rounding mode rounds float64 numbers to the nearest integer. If there are two nearest integers, then the number is rounded to the even one. This is the default rounding mode according to IEEE~754. I implemented the operator on ia32, x64, arm, arm64, mips, and mips64. I think there is a bug in the current implementation of the ppc simulator, which kept me from implementing the operator on ppc. According to my understanding of the ppc instruction manual, the FRIN instruction provides the right behavior for Float64RoundTiesEven. In the simulator, however, FRIN provides a different semantics. If there are two nearest integers, then the simulator returns the one which is further away form 0. BUG= Committed: https://crrev.com/a0134a6dc643afcc489ce87df652aa91a6bc9fc5 Cr-Commit-Position: refs/heads/master@{#32490}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M src/compiler/x87/instruction-selector-x87.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
5 years ago (2015-12-02 05:56:22 UTC) #2
Weiliang
lgtm
5 years ago (2015-12-02 06:44:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486323003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486323003/1
5 years ago (2015-12-02 06:44:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 07:03:10 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-02 07:03:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0134a6dc643afcc489ce87df652aa91a6bc9fc5
Cr-Commit-Position: refs/heads/master@{#32490}

Powered by Google App Engine
This is Rietveld 408576698