Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 14863013: Update SunSpider benchmark from 0.9.1 to 1.0. (Closed)

Created:
7 years, 7 months ago by tonyg
Modified:
7 years, 7 months ago
Reviewers:
bulach, danno
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Visibility:
Public.

Description

Update SunSpider benchmark from 0.9.1 to 1.0. SunSpider 1.0 results are not comparable to 0.9.1 results. This patch updates the chromium.perf bots to solely run 1.0 instead of 0.9.1. BUG=None TEST=tools/perf/run_multipage_benchmarks --browser=system sunspider tools/perf/page_sets/sunspider.json NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198964

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add missing files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -1221 lines) Patch
M chrome/test/data/sunspider/README.chromium View 1 1 chunk +3 lines, -10 lines 0 comments Download
A + chrome/test/data/sunspider/json2.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/sunspider/string-base64.html View 1 1 chunk +0 lines, -185 lines 0 comments Download
D chrome/test/data/sunspider/string-fasta.html View 1 1 chunk +0 lines, -135 lines 0 comments Download
D chrome/test/data/sunspider/string-tagcloud.html View 1 1 chunk +0 lines, -315 lines 0 comments Download
D chrome/test/data/sunspider/string-unpack-code.html View 1 1 chunk +0 lines, -117 lines 0 comments Download
D chrome/test/data/sunspider/string-validate-input.html View 1 1 chunk +0 lines, -139 lines 0 comments Download
M chrome/test/data/sunspider/sunspider.css View 1 1 chunk +4 lines, -4 lines 0 comments Download
A chrome/test/data/sunspider/sunspider.html View 1 1 chunk +81 lines, -0 lines 0 comments Download
A + chrome/test/data/sunspider/sunspider-1.0/driver.html View 1 5 chunks +12 lines, -9 lines 0 comments Download
A + chrome/test/data/sunspider/sunspider-1.0/results.html View 1 2 chunks +7 lines, -13 lines 0 comments Download
A + chrome/test/data/sunspider/sunspider-1.0/sunspider-test-prefix.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/sunspider/sunspider-analyze-results.js View 1 4 chunks +18 lines, -6 lines 0 comments Download
M chrome/test/data/sunspider/sunspider-compare-results.js View 1 3 chunks +40 lines, -24 lines 0 comments Download
D chrome/test/data/sunspider/sunspider-driver.html View 1 1 chunk +0 lines, -115 lines 0 comments Download
D chrome/test/data/sunspider/sunspider-record-result.js View 1 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/test/data/sunspider/sunspider-results.html View 1 1 chunk +0 lines, -114 lines 0 comments Download
D chrome/test/data/sunspider/sunspider-test-prefix.js View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/sunspider.json View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/perf_tools/sunspider.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tonyg
ptal
7 years, 7 months ago (2013-05-07 22:05:00 UTC) #1
bulach
lgtm, but please let danno chime in. one comment below, feel free to ignore. https://codereview.chromium.org/14863013/diff/1/chrome/test/data/sunspider/README.chromium ...
7 years, 7 months ago (2013-05-08 08:45:31 UTC) #2
danno
I can't comment on the mechanics of how to get this into the Chrome testing ...
7 years, 7 months ago (2013-05-08 12:18:09 UTC) #3
tonyg
On 2013/05/08 08:45:31, bulach wrote: > lgtm, but please let danno chime in. > > ...
7 years, 7 months ago (2013-05-08 19:09:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/14863013/29001
7 years, 7 months ago (2013-05-08 19:24:29 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-08 19:27:36 UTC) #6
Message was sent while issue was closed.
Change committed as 198964

Powered by Google App Engine
This is Rietveld 408576698