Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7596)

Unified Diff: Source/devtools/front_end/SettingsScreen.js

Issue 14862010: DevTools: minor UI tweaks in the settings UI. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/Settings.js ('k') | Source/devtools/front_end/helpScreen.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/SettingsScreen.js
diff --git a/Source/devtools/front_end/SettingsScreen.js b/Source/devtools/front_end/SettingsScreen.js
index 77a285b58857dc017668725035b606c4c1fa2351..5f253f02dc4509efe624c3ddeca7976fa3b7ab9f 100644
--- a/Source/devtools/front_end/SettingsScreen.js
+++ b/Source/devtools/front_end/SettingsScreen.js
@@ -714,8 +714,17 @@ WebInspector.TetheringSettingsTab.prototype = {
if (this._paragraphElement)
return;
- this._paragraphElement = this._appendSection(WebInspector.UIString("Mappings"));
WebInspector.SettingsTab.prototype.wasShown.call(this);
+
+ var labelElement = this._appendSection();
+ labelElement.addStyleClass("tethering-help-info");
+ labelElement.textContent =
+ WebInspector.UIString("Creates a listen TCP port on your device that maps to a particular TCP port accessible from the host machine.");
+ labelElement.createChild("br");
+ labelElement.createChild("div", "tethering-help-title-left").textContent = WebInspector.UIString("Device port");
+ labelElement.createChild("div", "tethering-help-title-right").textContent = WebInspector.UIString("Target");
+
+ this._paragraphElement = this._appendSection();
var mappingEntries = WebInspector.settings.portForwardings.get();
for (var i = 0; i < mappingEntries.length; ++i)
this._addMappingRow(mappingEntries[i].port, mappingEntries[i].location, false);
@@ -733,7 +742,7 @@ WebInspector.TetheringSettingsTab.prototype = {
_addMappingRow: function(port, location, focus)
{
var mappingRow = this._paragraphElement.createChild("div", "workspace-settings-row");
- var portElement = mappingRow.createChild("input");
+ var portElement = mappingRow.createChild("input", "tethering-port-input");
portElement.type = "text";
portElement.value = port || "";
if (!port)
« no previous file with comments | « Source/devtools/front_end/Settings.js ('k') | Source/devtools/front_end/helpScreen.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698