Improve performance of String.fromCharCodes by implementing it in Dart. Add tow internal natives to…

runtime/lib/string.cc

Index: runtime/lib/string.cc
===================================================================
--- runtime/lib/string.cc	(revision 22374)
+++ runtime/lib/string.cc	(working copy)
@@ -121,6 +121,23 @@
 }
 
 
+DEFINE_NATIVE_ENTRY(OneByteString_allocate, 1) {
+  GET_NON_NULL_NATIVE_ARGUMENT(Smi, length_obj, arguments->NativeArgAt(0));
+  return OneByteString::New(length_obj.Value(), Heap::kNew);
+}
+
+
+DEFINE_NATIVE_ENTRY(OneByteString_setAt, 3) {
+  const String& receiver = String::CheckedHandle(arguments->NativeArgAt(0));

[siva, 2013/05/03 23:05:01]

May be do a GET_NON_NULL_NATIVE_ARGUMENT(...)

[srdjan, 2013/05/03 23:36:37]

Done.

+  ASSERT(receiver.IsOneByteString());
+  GET_NON_NULL_NATIVE_ARGUMENT(Smi, index_obj, arguments->NativeArgAt(1));
+  GET_NON_NULL_NATIVE_ARGUMENT(Smi, code_point_obj, arguments->NativeArgAt(2));
+  ASSERT((0 <= code_point_obj.Value()) && (code_point_obj.Value() <= 0xFF);
+  OneByteString::SetCharAt(receiver, index_obj.Value(), code_point_obj.Value());
+  return Object::null();
+}
+
+
 DEFINE_NATIVE_ENTRY(String_getHashCode, 1) {
   const String& receiver = String::CheckedHandle(arguments->NativeArgAt(0));
   intptr_t hash_val = receiver.Hash();