chrome/browser/extensions/api/push_messaging/push_messaging_api.h - Issue 14862004: Fix null pointer bug, add better logging to see why pointer is sometimes null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/push_messaging/push_messaging_api.h

Issue 14862004: Fix null pointer bug, add better logging to see why pointer is sometimes null. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/background/background_mode_manager.h ('k') | chrome/browser/notifications/sync_notifier/chrome_notifier_service.cc » ('j') | chrome/browser/notifications/sync_notifier/chrome_notifier_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/push_messaging/push_messaging_api.h

diff --git a/chrome/browser/extensions/api/push_messaging/push_messaging_api.h b/chrome/browser/extensions/api/push_messaging/push_messaging_api.h

index 3c9c803bcd083c91ed8327cdec560aee72847999..e1709e8ad98cb83a71c7d50b739f1af4ba54309a 100644

--- a/chrome/browser/extensions/api/push_messaging/push_messaging_api.h

+++ b/chrome/browser/extensions/api/push_messaging/push_messaging_api.h

@@ -91,7 +91,7 @@ class PushMessagingGetChannelIdFunction

scoped_ptr<ObfuscatedGaiaIdFetcher> fetcher_;

bool interactive_;

- // We use this to register for notifications if the logon attept succeeds.

+ // We use this to register for notifications if the login attempt succeeds.

content::NotificationRegistrar registrar_;

DISALLOW_COPY_AND_ASSIGN(PushMessagingGetChannelIdFunction);