Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1486173003:
Partial revert of "Use std::tie() for operator< in components" (Closed)
|
Created:
5 years ago by jsbell Modified:
5 years ago CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPartial revert of "Use std::tie() for operator< in components"
One use of std::tie() for operator< implementation is tripping a
compiler warning on Android:
variable tracking size limit exceeded with -fvar-tracking-assignments
This causes the file to be recompiled; we could bump the
max-vartrack-size limit but it's unlikely to be worth it.
This is a partial revert of https://codereview.chromium.org/1447153002/
BUG=555171
R=thakis@chromium.org,asvitkine@chromium.org
TBR=vabr@chromium.org
Committed: https://crrev.com/4c0ccc4d79e59a4b61d6bee1992e039b3efc7c98
Cr-Commit-Position: refs/heads/master@{#362834}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Added comment #Messages
Total messages: 16 (7 generated)
thakis@, alexei@ - please take a look? (and check the commit box if you're happy with it)
lgtm with comment https://codereview.chromium.org/1486173003/diff/1/components/autofill/core/co... File components/autofill/core/common/form_field_data.cc (right): https://codereview.chromium.org/1486173003/diff/1/components/autofill/core/co... components/autofill/core/common/form_field_data.cc:118: bool FormFieldData::operator<(const FormFieldData& field) const { add a comment why this doesn't use std::tie
The CQ bit was checked by jsbell@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org Link to the patchset: https://codereview.chromium.org/1486173003/#ps20001 (title: "Added comment")
https://codereview.chromium.org/1486173003/diff/1/components/autofill/core/co... File components/autofill/core/common/form_field_data.cc (right): https://codereview.chromium.org/1486173003/diff/1/components/autofill/core/co... components/autofill/core/common/form_field_data.cc:118: bool FormFieldData::operator<(const FormFieldData& field) const { On 2015/12/02 02:14:03, Nico wrote: > add a comment why this doesn't use std::tie Done.
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486173003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486173003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
Description was changed from ========== Partial revert of "Use std::tie() for operator< in components" One use of std::tie() for operator< implementation is tripping a compiler warning on Android: variable tracking size limit exceeded with -fvar-tracking-assignments This causes the file to be recompiled; we could bump the max-vartrack-size limit but it's unlikely to be worth it. This is a partial revert of https://codereview.chromium.org/1447153002/ BUG=555171 R=thakis@chromium.org,asvitkine@chromium.org ========== to ========== Partial revert of "Use std::tie() for operator< in components" One use of std::tie() for operator< implementation is tripping a compiler warning on Android: variable tracking size limit exceeded with -fvar-tracking-assignments This causes the file to be recompiled; we could bump the max-vartrack-size limit but it's unlikely to be worth it. This is a partial revert of https://codereview.chromium.org/1447153002/ BUG=555171 R=thakis@chromium.org,asvitkine@chromium.org TBR=vabr@chromium.org ==========
The CQ bit was checked by jsbell@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486173003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486173003/20001
Message was sent while issue was closed.
Description was changed from ========== Partial revert of "Use std::tie() for operator< in components" One use of std::tie() for operator< implementation is tripping a compiler warning on Android: variable tracking size limit exceeded with -fvar-tracking-assignments This causes the file to be recompiled; we could bump the max-vartrack-size limit but it's unlikely to be worth it. This is a partial revert of https://codereview.chromium.org/1447153002/ BUG=555171 R=thakis@chromium.org,asvitkine@chromium.org TBR=vabr@chromium.org ========== to ========== Partial revert of "Use std::tie() for operator< in components" One use of std::tie() for operator< implementation is tripping a compiler warning on Android: variable tracking size limit exceeded with -fvar-tracking-assignments This causes the file to be recompiled; we could bump the max-vartrack-size limit but it's unlikely to be worth it. This is a partial revert of https://codereview.chromium.org/1447153002/ BUG=555171 R=thakis@chromium.org,asvitkine@chromium.org TBR=vabr@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Partial revert of "Use std::tie() for operator< in components" One use of std::tie() for operator< implementation is tripping a compiler warning on Android: variable tracking size limit exceeded with -fvar-tracking-assignments This causes the file to be recompiled; we could bump the max-vartrack-size limit but it's unlikely to be worth it. This is a partial revert of https://codereview.chromium.org/1447153002/ BUG=555171 R=thakis@chromium.org,asvitkine@chromium.org TBR=vabr@chromium.org ========== to ========== Partial revert of "Use std::tie() for operator< in components" One use of std::tie() for operator< implementation is tripping a compiler warning on Android: variable tracking size limit exceeded with -fvar-tracking-assignments This causes the file to be recompiled; we could bump the max-vartrack-size limit but it's unlikely to be worth it. This is a partial revert of https://codereview.chromium.org/1447153002/ BUG=555171 R=thakis@chromium.org,asvitkine@chromium.org TBR=vabr@chromium.org Committed: https://crrev.com/4c0ccc4d79e59a4b61d6bee1992e039b3efc7c98 Cr-Commit-Position: refs/heads/master@{#362834} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4c0ccc4d79e59a4b61d6bee1992e039b3efc7c98 Cr-Commit-Position: refs/heads/master@{#362834} |
