base/debug/trace_event_memory_unittest.cc - Issue 148613014: CC: Add 'cc-benchmark' traces for minimal tracing in benchmarks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/debug/trace_event_memory_unittest.cc

Issue 148613014: CC: Add 'cc-benchmark' traces for minimal tracing in benchmarks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Minimum overhead toplevel tracing. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/debug/trace_event_memory_unittest.cc

diff --git a/base/debug/trace_event_memory_unittest.cc b/base/debug/trace_event_memory_unittest.cc

index 3f5cad3ede213cb8b59e63577b942dbe72d26519..c0a1568e35712a222abb2c9139910e7cca75ea27 100644

--- a/base/debug/trace_event_memory_unittest.cc

+++ b/base/debug/trace_event_memory_unittest.cc

@@ -164,10 +164,10 @@ TEST_F(TraceMemoryTest, AppendHeapProfileLineAsTraceFormat) {

AppendHeapProfileLineAsTraceFormat(input.str().c_str(), &output));

EXPECT_EQ(kExpectedOutput, output);

- // Input with with the category "toplevel".

+ // Input with with the category "task".

// TODO(jamescook): Eliminate this special case and move the logic to the

// trace viewer code.

- const char kTaskCategory[] = "toplevel";

+ const char kTaskCategory[] = "task";

const char kTaskName[] = "TaskName";

std::ostringstream input2;

input2 << " 68: 4195 [ 1087: 98009] @ " << &kTaskCategory << " "

« no previous file with comments | « base/debug/trace_event_memory.cc ('k') | base/message_loop/incoming_task_queue.cc » ('j') | base/message_loop/message_loop.cc » ('J')