Issue 148613008: [Aura] RenderWidgetHostViewAura fixes for embedding fullscreen views within browser tabs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 148613008: [Aura] RenderWidgetHostViewAura fixes for embedding fullscreen views within browser tabs. (Closed)

Created:
6 years, 10 months ago by miu

Modified:
6 years, 10 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, joi+watch-content_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Aura] RenderWidgetHostViewAura fixes for embedding fullscreen views within browser tabs. 1. Modify OnBoundsChanged() to unconditionally call SetSize() to propagate all aura::Window size changes (e.g., due to container layout) to the renderer. There are already re-entrancy and redundancy guards in place, making this safe/sane. 2. Apply coordinate conversion for mouse events propagated to the parent->delegate. This was previously overlooked because it was assumed WebContentsViewAura was the only parent->delegate, and WCVA does not do anything with mouse coordinates. BUG=256870 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247628