Changes the keyboard background to a linear gradient.

Changes the keyboard background to a linear gradient.

BUG=332073
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247732

[rsadam, 2014-01-28 16:31:02]

Hey Biao! Would you mind taking a look at this 2 line CL?

[rsadam, 2014-01-28 22:46:29]

This should fix the image issue! Essentially since dark keys don't have a
gradient (they're just #222222) and all keys with images are dark keys, we can
use the gradients as intended on light keys.

[bshe, 2014-01-29 01:17:07]

https://codereview.chromium.org/148613007/diff/20001/ui/keyboard/resources/ma...
File ui/keyboard/resources/main.css (right):

https://codereview.chromium.org/148613007/diff/20001/ui/keyboard/resources/ma...
ui/keyboard/resources/main.css:44: border-top-color: #a4a4a4 !important;
Sorry. I probably missed this earlier, but why these rules need to have
!important. Generally speaking, we shouldn't use !important in CSS rules.

https://codereview.chromium.org/148613007/diff/20001/ui/keyboard/resources/ma...
ui/keyboard/resources/main.css:48: -webkit-box-shadow: inset 0px 1px #969696,
inset 0px -1px #6f6f6f !important;
-webkit-box-shadow, border-bottom-color, border-top-color looks the same as
above. Can they be merged?

[rsadam, 2014-01-29 02:20:16]

extra newline

[rsadam, 2014-01-29 02:21:09]

On 2014/01/29 02:20:16, rsadam wrote:
> extra newline

Oops I didn't realize git cl upload -m auto published.

[rsadam, 2014-01-29 02:56:48]

https://codereview.chromium.org/148613007/diff/20001/ui/keyboard/resources/ma...
File ui/keyboard/resources/main.css (right):

https://codereview.chromium.org/148613007/diff/20001/ui/keyboard/resources/ma...
ui/keyboard/resources/main.css:44: border-top-color: #a4a4a4 !important;
On 2014/01/29 01:17:07, bshe wrote:
> Sorry. I probably missed this earlier, but why these rules need to have
> !important. Generally speaking, we shouldn't use !important in CSS rules.

Found a way around it! Done!

https://codereview.chromium.org/148613007/diff/20001/ui/keyboard/resources/ma...
ui/keyboard/resources/main.css:48: -webkit-box-shadow: inset 0px 1px #969696,
inset 0px -1px #6f6f6f !important;
On 2014/01/29 01:17:07, bshe wrote:
> -webkit-box-shadow, border-bottom-color, border-top-color looks the same as
> above. Can they be merged?

Done.

[bshe, 2014-01-29 16:37:49]

On 2014/01/29 02:56:48, rsadam wrote:
>
https://codereview.chromium.org/148613007/diff/20001/ui/keyboard/resources/ma...
> File ui/keyboard/resources/main.css (right):
> 
>
https://codereview.chromium.org/148613007/diff/20001/ui/keyboard/resources/ma...
> ui/keyboard/resources/main.css:44: border-top-color: #a4a4a4 !important;
> On 2014/01/29 01:17:07, bshe wrote:
> > Sorry. I probably missed this earlier, but why these rules need to have
> > !important. Generally speaking, we shouldn't use !important in CSS rules.
> 
> Found a way around it! Done!
> 
>
https://codereview.chromium.org/148613007/diff/20001/ui/keyboard/resources/ma...
> ui/keyboard/resources/main.css:48: -webkit-box-shadow: inset 0px 1px #969696,
> inset 0px -1px #6f6f6f !important;
> On 2014/01/29 01:17:07, bshe wrote:
> > -webkit-box-shadow, border-bottom-color, border-top-color looks the same as
> > above. Can they be merged?
> 
> Done.

great. lgtm

[commit-bot: I haz the power, 2014-01-29 16:38:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsadam@chromium.org/148613007/80001

[commit-bot: I haz the power, 2014-01-29 19:53:46]

Change committed as 247732