Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: tests/standalone/debugger/debug_lib.dart

Issue 148613002: Mark debugger test as failed if debug target crashes (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/debugger/debug_lib.dart
===================================================================
--- tests/standalone/debugger/debug_lib.dart (revision 32023)
+++ tests/standalone/debugger/debug_lib.dart (working copy)
@@ -660,13 +660,18 @@
});
}
var targetPid = targetProcess.pid;
- print("Sending kill signal to process $targetPid...");
- targetProcess.kill();
- // If the process was already dead exitCode is already
+ if (errorsDetected || !shutdownEventSeen) {
+ print("Sending kill signal to process $targetPid...");
+ targetProcess.kill();
+ }
+ // If the process was already dead, exitCode is
// available and we call exit() in the next event loop cycle.
// Otherwise this will wait for the process to exit.
targetProcess.exitCode.then((exitCode) {
print("process $targetPid terminated with exit code $exitCode.");
+ if (exitCode != 0) {
+ error("Error: target process died with exit code $exitCode");
+ }
if (errorsDetected) {
print("\n===== Errors detected: =====");
for (int i = 0; i < errors.length; i++) print(errors[i]);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698