Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3258)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java

Issue 1486053003: Android: Add support for TraceEvent before the native library is loaded. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Proper locking. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
index 8f65f963a0fff3a6728583c434fb23cfdb755488..dfb8c8138e911da883277010406223e142152307 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
@@ -136,12 +136,21 @@ public class ChromeLauncherActivity extends Activity
*/
@Override
public void onCreate(Bundle savedInstanceState) {
+ TraceEvent.begin("ChromeLauncherActivity");
+ TraceEvent.begin("ChromeLauncherActivity.onCreate");
+ try {
+ doOnCreate(savedInstanceState);
+ } finally {
+ TraceEvent.end("ChromeLauncherActivity.onCreate");
+ }
+ }
+
+ private final void doOnCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
// This Activity is only transient. It launches another activity and
// terminates itself. However, some of the work is performed outside of
// {@link Activity#onCreate()}. To capture this, the TraceEvent starts
// in onCreate(), and ends in onPause().
- TraceEvent.begin("ChromeLauncherActivity");
// Needs to be called as early as possible, to accurately capture the
// time at which the intent was received.
IntentHandler.addTimestampToIntent(getIntent());
@@ -220,8 +229,8 @@ public class ChromeLauncherActivity extends Activity
}
@Override
- public void onPause() {
- super.onPause();
+ public void onDestroy() {
pasko 2015/12/15 17:52:59 changing onPause() to onDestroy() looks like fixin
Benoit L 2016/01/06 12:50:06 Yes, as mentioned in the CL description. Basically
pasko 2016/01/06 13:50:10 OK, worksforme, thank you for explanation
+ super.onDestroy();
TraceEvent.end("ChromeLauncherActivity");
}

Powered by Google App Engine
This is Rietveld 408576698