[webnfc] Introduce NFC mojo service.

[webnfc] Introduce NFC mojo service.

This patch adds NFC mojo service interface definition
that will be used to implement functionality required
by the W3C WebNFC module.

BUG=520391
Committed: https://crrev.com/3e3f71c7c789109fa49aa9818620551025ddfed1
Cr-Commit-Position: refs/heads/master@{#363455}

[shalamov, 2015-12-03 09:16:52]

Description was changed from

==========
[webnfc] Introduce NFC mojo service.

This patch adds NFC mojo service interface definition
that will be used to implement functionality required
by the W3C WebNFC module.

BUG=520391
==========

to

==========
[webnfc] Introduce NFC mojo service.

This patch adds NFC mojo service interface definition
that will be used to implement functionality required
by the W3C WebNFC module.

BUG=520391
==========

[shalamov, 2015-12-03 09:16:52]

alexander.shalamov@intel.com changed reviewers:
+ armansito@chromium.org, jam@chromium.org, keybuk@chromium.org

[shalamov, 2015-12-03 09:30:50]

alexander.shalamov@intel.com changed reviewers:
+ kenneth.christiansen@gmail.com, kenneth.r.christiansen@intel.com,
rijubrata.bhaumik@intel.com

[shalamov, 2015-12-03 09:30:51]

I'm implementing enablers for W3C WebNFC API, this CL is required to implement
dispatcher that will use NFC mojo service.

Initial implementation of the service (skeleton) for Android platform is here:
https://crrev.com/1486043002 .

Do I need to add someone from security team to review API?

PTAL

[armansito, 2015-12-04 00:41:16]

device/nfc lgtm

[jam, 2015-12-04 05:17:27]

> I'm implementing enablers for W3C WebNFC API, this CL is required to implement
> dispatcher that will use NFC mojo service.
> 
> Initial implementation of the service (skeleton) for Android platform is here:
> https://crrev.com/1486043002 .
> 
> Do I need to add someone from security team to review API?

Yes security team reviews all IPC files (chrome ipc or mojo icp)

> 
> PTAL

I dont' understand why content/browser and content/renderer depend on this new
target which generates mojom files? they don't call them.

[jam, 2015-12-04 05:17:28]

> I'm implementing enablers for W3C WebNFC API, this CL is required to implement
> dispatcher that will use NFC mojo service.
> 
> Initial implementation of the service (skeleton) for Android platform is here:
> https://crrev.com/1486043002 .
> 
> Do I need to add someone from security team to review API?

Yes security team reviews all IPC files (chrome ipc or mojo icp)

> 
> PTAL

I dont' understand why content/browser and content/renderer depend on this new
target which generates mojom files? they don't call them.

[shalamov, 2015-12-04 09:22:20]

On 2015/12/04 05:17:28, jam wrote:
> > I'm implementing enablers for W3C WebNFC API, this CL is required to
implement
> > dispatcher that will use NFC mojo service.
> > 
> > Initial implementation of the service (skeleton) for Android platform is
here:
> > https://crrev.com/1486043002 .
> > 
> > Do I need to add someone from security team to review API?
> 
> Yes security team reviews all IPC files (chrome ipc or mojo icp)
> 
> > 
> > PTAL
> 
> I dont' understand why content/browser and content/renderer depend on this new
> target which generates mojom files? they don't call them.

Thanks for pointing out. I will add dependency when service / dispatcher would
be implemented.

[shalamov, 2015-12-04 09:27:54]

alexander.shalamov@intel.com changed reviewers:
+ cdn@chromium.org, cevans@chromium.org, tsepez@chromium.org

[Tom Sepez, 2015-12-04 17:32:51]

LGTM, but please also CC me when you have an implementation.

[shalamov, 2015-12-07 11:56:26]

The CQ bit was checked by alexander.shalamov@intel.com

[shalamov, 2015-12-07 11:56:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
armansito@chromium.org
Link to the patchset: https://codereview.chromium.org/1486033002/#ps40001
(title: "Remove dependency from content / browser")

[commit-bot: I haz the power, 2015-12-07 11:56:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1486033002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1486033002/40001

[commit-bot: I haz the power, 2015-12-07 12:04:43]

Description was changed from

==========
[webnfc] Introduce NFC mojo service.

This patch adds NFC mojo service interface definition
that will be used to implement functionality required
by the W3C WebNFC module.

BUG=520391
==========

to

==========
[webnfc] Introduce NFC mojo service.

This patch adds NFC mojo service interface definition
that will be used to implement functionality required
by the W3C WebNFC module.

BUG=520391
==========

[commit-bot: I haz the power, 2015-12-07 12:04:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-07 12:05:31]

Description was changed from

==========
[webnfc] Introduce NFC mojo service.

This patch adds NFC mojo service interface definition
that will be used to implement functionality required
by the W3C WebNFC module.

BUG=520391
==========

to

==========
[webnfc] Introduce NFC mojo service.

This patch adds NFC mojo service interface definition
that will be used to implement functionality required
by the W3C WebNFC module.

BUG=520391

Committed: https://crrev.com/3e3f71c7c789109fa49aa9818620551025ddfed1
Cr-Commit-Position: refs/heads/master@{#363455}
==========

[commit-bot: I haz the power, 2015-12-07 12:05:32]

Patchset 3 (id:??) landed as
https://crrev.com/3e3f71c7c789109fa49aa9818620551025ddfed1
Cr-Commit-Position: refs/heads/master@{#363455}

[shalamov, 2015-12-07 13:25:08]

Description was changed from

==========
[webnfc] Introduce NFC mojo service.

This patch adds NFC mojo service interface definition
that will be used to implement functionality required
by the W3C WebNFC module.

BUG=520391

Committed: https://crrev.com/3e3f71c7c789109fa49aa9818620551025ddfed1
Cr-Commit-Position: refs/heads/master@{#363455}
==========

to

==========
[webnfc] Introduce NFC mojo service.

This patch adds NFC mojo service interface definition
that will be used to implement functionality required
by the W3C WebNFC module.

BUG=520391

Committed: https://crrev.com/3e3f71c7c789109fa49aa9818620551025ddfed1
Cr-Commit-Position: refs/heads/master@{#363455}
==========

[shalamov, 2015-12-07 13:25:08]

alexander.shalamov@intel.com changed reviewers:
- cdn@chromium.org